* [axboe-block:rw_iter 224/415] drivers/watchdog/eurotechwdt.c:199: warning: Function parameter or struct member 'iocb' not described in 'eurwdt_write'
@ 2024-04-11 6:54 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-04-11 6:54 UTC (permalink / raw
To: Jens Axboe; +Cc: oe-kbuild-all
tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git rw_iter
head: 2cdbd541e4481cb9cbd08913e0586dc8a2570aec
commit: 3c90dc14ee8baba7b051b809e8369c8328c2a2a9 [224/415] watchdog: eurotechwdt: convert to read/write iterators
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240411/202404111433.wl4NLc6m-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240411/202404111433.wl4NLc6m-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404111433.wl4NLc6m-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/watchdog/eurotechwdt.c:199: warning: Function parameter or struct member 'iocb' not described in 'eurwdt_write'
>> drivers/watchdog/eurotechwdt.c:199: warning: Function parameter or struct member 'from' not described in 'eurwdt_write'
>> drivers/watchdog/eurotechwdt.c:199: warning: Excess function parameter 'file' description in 'eurwdt_write'
>> drivers/watchdog/eurotechwdt.c:199: warning: Excess function parameter 'buf' description in 'eurwdt_write'
>> drivers/watchdog/eurotechwdt.c:199: warning: Excess function parameter 'count' description in 'eurwdt_write'
>> drivers/watchdog/eurotechwdt.c:199: warning: Excess function parameter 'ppos' description in 'eurwdt_write'
vim +199 drivers/watchdog/eurotechwdt.c
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 186
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 187 /**
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 188 * eurwdt_write:
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 189 * @file: file handle to the watchdog
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 190 * @buf: buffer to write (unused as data does not matter here
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 191 * @count: count of bytes
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 192 * @ppos: pointer to the position to write. No seeks allowed
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 193 *
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 194 * A write to a watchdog device is defined as a keepalive signal. Any
08a884cf030481 drivers/watchdog/eurotechwdt.c shaomin Deng 2022-08-08 195 * write of data will do, as we don't define content meaning.
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 196 */
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 197
3c90dc14ee8bab drivers/watchdog/eurotechwdt.c Jens Axboe 2024-04-08 198 static ssize_t eurwdt_write(struct kiocb *iocb, struct iov_iter *from)
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 @199 {
3c90dc14ee8bab drivers/watchdog/eurotechwdt.c Jens Axboe 2024-04-08 200 size_t count = iov_iter_count(from);
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 201 if (count) {
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 202 if (!nowayout) {
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 203 size_t i;
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 204
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 205 eur_expect_close = 0;
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 206
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 207 for (i = 0; i != count; i++) {
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 208 char c;
3c90dc14ee8bab drivers/watchdog/eurotechwdt.c Jens Axboe 2024-04-08 209 if (get_iter(c, from))
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 210 return -EFAULT;
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 211 if (c == 'V')
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 212 eur_expect_close = 42;
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 213 }
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 214 }
89ea2429873e69 drivers/watchdog/eurotechwdt.c Alan Cox 2008-05-19 215 spin_lock(&eurwdt_lock);
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 216 eurwdt_ping(); /* the default timeout */
89ea2429873e69 drivers/watchdog/eurotechwdt.c Alan Cox 2008-05-19 217 spin_unlock(&eurwdt_lock);
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 218 }
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 219 return count;
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 220 }
^1da177e4c3f41 drivers/char/watchdog/eurotechwdt.c Linus Torvalds 2005-04-16 221
:::::: The code at line 199 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-11 6:54 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-11 6:54 [axboe-block:rw_iter 224/415] drivers/watchdog/eurotechwdt.c:199: warning: Function parameter or struct member 'iocb' not described in 'eurwdt_write' kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).