* [jfern:sched/dlserver.update_h_nr 1/1] kernel/sched/fair.c:5830:13: warning: conflicting types for 'update_h_nr_running'; have 'void(struct cfs_rq *, int)'
@ 2024-04-18 20:29 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-04-18 20:29 UTC (permalink / raw
To: Joel Fernandes (Google); +Cc: oe-kbuild-all
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git sched/dlserver.update_h_nr
head: 4e843586ff1b3b77e5244d0128facac6330490a4
commit: 4e843586ff1b3b77e5244d0128facac6330490a4 [1/1] Prototype: Update h_nr_running from single place to stop/start dl server
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240419/202404190428.SuQhraKV-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240419/202404190428.SuQhraKV-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404190428.SuQhraKV-lkp@intel.com/
All warnings (new ones prefixed by >>):
kernel/sched/fair.c:633:5: warning: no previous prototype for 'sched_update_scaling' [-Wmissing-prototypes]
633 | int sched_update_scaling(void)
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c: In function 'throttle_cfs_rq':
kernel/sched/fair.c:5119:17: error: implicit declaration of function 'update_h_nr_running' [-Werror=implicit-function-declaration]
5119 | update_h_nr_running(qcfs_rq, -1 * task_delta);
| ^~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c: At top level:
>> kernel/sched/fair.c:5830:13: warning: conflicting types for 'update_h_nr_running'; have 'void(struct cfs_rq *, int)'
5830 | static void update_h_nr_running(struct cfs_rq *cfs_rq, int delta)
| ^~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:5830:13: error: static declaration of 'update_h_nr_running' follows non-static declaration
kernel/sched/fair.c:5119:17: note: previous implicit declaration of 'update_h_nr_running' with type 'void(struct cfs_rq *, int)'
5119 | update_h_nr_running(qcfs_rq, -1 * task_delta);
| ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +5830 kernel/sched/fair.c
5829
> 5830 static void update_h_nr_running(struct cfs_rq *cfs_rq, int delta)
5831 {
5832 int old_h_nr_running, new_h_nr_running;
5833 bool root = (&rq_of(cfs_rq)->cfs == cfs_rq);
5834
5835 if (root) {
5836 old_h_nr_running = cfs_rq->h_nr_running;
5837 }
5838
5839 new_h_nr_running = cfs_rq->h_nr_running + delta;
5840 cfs_rq->h_nr_running = new_h_nr_running;
5841
5842 if (root && !!old_h_nr_running != !!new_h_nr_running) {
5843 if (new_h_nr_running) {
5844 dl_server_start(&rq_of(cfs_rq)->fair_server);
5845 } else {
5846 dl_server_stop(&rq_of(cfs_rq)->fair_server);
5847 }
5848 }
5849 }
5850
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-18 20:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-18 20:29 [jfern:sched/dlserver.update_h_nr 1/1] kernel/sched/fair.c:5830:13: warning: conflicting types for 'update_h_nr_running'; have 'void(struct cfs_rq *, int)' kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).