* [PATCH v8 0/4] LVDS Controller Support for SAM9X75 SoC
@ 2024-04-21 1:10 Dharma Balasubiramani
2024-04-21 1:10 ` [PATCH v8 1/4] dt-bindings: display: bridge: add sam9x75-lvds binding Dharma Balasubiramani
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Dharma Balasubiramani @ 2024-04-21 1:10 UTC (permalink / raw
To: dmitry . baryshkov @ linaro . org, andrzej . hajda @ intel . com,
neil . armstrong @ linaro . org, rfoss @ kernel . org,
Laurent . pinchart @ ideasonboard . com, jonas @ kwiboo . se,
jernej . skrabec @ gmail . com,
maarten . lankhorst @ linux . intel . com, mripard @ kernel . org,
tzimmermann @ suse . de, airlied @ gmail . com,
daniel @ ffwll . ch, robh+dt @ kernel . org,
krzysztof . kozlowski+dt @ linaro . org, conor+dt @ kernel . org,
linux @ armlinux . org . uk, Nicolas . Ferre @ microchip . com,
alexandre . belloni @ bootlin . com,
claudiu . beznea @ tuxon . dev, Manikandan . M @ microchip . com,
arnd @ arndb . de, geert+renesas @ glider . be,
Jason @ zx2c4 . com, mpe @ ellerman . id . au,
gerg @ linux-m68k . org, rdunlap @ infradead . org,
vbabka @ suse . cz, dri-devel @ lists . freedesktop . org,
devicetree @ vger . kernel . org,
linux-kernel @ vger . kernel . org,
oe-kbuild-all @ lists . linux . dev,
Hari . PrasathGE @ microchip . com
Cc: Dharma Balasubiramani
This patch series introduces LVDS controller support for the SAM9X75 SoC. The
LVDS controller is designed to work with Microchip's sam9x7 series
System-on-Chip (SoC) devices, providing Low Voltage Differential Signaling
capabilities.
Patch series Changelog:
- Include configs: at91: Enable LVDS serializer
- include all necessary To/Cc entries.
The Individual Changelogs are available on the respective patches.
Dharma Balasubiramani (4):
dt-bindings: display: bridge: add sam9x75-lvds binding
drm/bridge: add lvds controller support for sam9x7
MAINTAINERS: add SAM9X7 SoC's LVDS controller
ARM: configs: at91: Enable LVDS serializer support
.../bridge/microchip,sam9x75-lvds.yaml | 55 +++++
MAINTAINERS | 8 +
arch/arm/configs/at91_dt_defconfig | 1 +
drivers/gpu/drm/bridge/Kconfig | 7 +
drivers/gpu/drm/bridge/Makefile | 1 +
drivers/gpu/drm/bridge/microchip-lvds.c | 229 ++++++++++++++++++
6 files changed, 301 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/bridge/microchip,sam9x75-lvds.yaml
create mode 100644 drivers/gpu/drm/bridge/microchip-lvds.c
--
2.25.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v8 1/4] dt-bindings: display: bridge: add sam9x75-lvds binding
2024-04-21 1:10 [PATCH v8 0/4] LVDS Controller Support for SAM9X75 SoC Dharma Balasubiramani
@ 2024-04-21 1:10 ` Dharma Balasubiramani
2024-04-21 1:10 ` [PATCH v8 2/4] drm/bridge: add lvds controller support for sam9x7 Dharma Balasubiramani
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Dharma Balasubiramani @ 2024-04-21 1:10 UTC (permalink / raw
To: dmitry . baryshkov @ linaro . org, andrzej . hajda @ intel . com,
neil . armstrong @ linaro . org, rfoss @ kernel . org,
Laurent . pinchart @ ideasonboard . com, jonas @ kwiboo . se,
jernej . skrabec @ gmail . com,
maarten . lankhorst @ linux . intel . com, mripard @ kernel . org,
tzimmermann @ suse . de, airlied @ gmail . com,
daniel @ ffwll . ch, robh+dt @ kernel . org,
krzysztof . kozlowski+dt @ linaro . org, conor+dt @ kernel . org,
linux @ armlinux . org . uk, Nicolas . Ferre @ microchip . com,
alexandre . belloni @ bootlin . com,
claudiu . beznea @ tuxon . dev, Manikandan . M @ microchip . com,
arnd @ arndb . de, geert+renesas @ glider . be,
Jason @ zx2c4 . com, mpe @ ellerman . id . au,
gerg @ linux-m68k . org, rdunlap @ infradead . org,
vbabka @ suse . cz, dri-devel @ lists . freedesktop . org,
devicetree @ vger . kernel . org,
linux-kernel @ vger . kernel . org,
oe-kbuild-all @ lists . linux . dev,
Hari . PrasathGE @ microchip . com
Cc: Dharma Balasubiramani, Rob Herring
Add the 'sam9x75-lvds' compatible binding, which describes the Low Voltage
Differential Signaling (LVDS) Controller found on some Microchip's sam9x7
series System-on-Chip (SoC) devices. This binding will be used to define
the properties and configuration for the LVDS Controller in DT.
Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Changelog
v7 -> v8
v6 -> v7
v5 -> v6
v4 -> v5
- No changes.
v3 -> v4
- Rephrase the commit subject.
v2 -> v3
- No changes.
v1 -> v2
- Remove '|' in description, as there is no formatting to preserve.
- Remove 'gclk' from clock-names as there is only one clock(pclk).
- Remove the unused headers and include only used ones.
- Change the compatible name specific to SoC (sam9x75) instead of entire series.
- Change file name to match the compatible name.
---
.../bridge/microchip,sam9x75-lvds.yaml | 55 +++++++++++++++++++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/bridge/microchip,sam9x75-lvds.yaml
diff --git a/Documentation/devicetree/bindings/display/bridge/microchip,sam9x75-lvds.yaml b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x75-lvds.yaml
new file mode 100644
index 000000000000..862ef441ac9f
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x75-lvds.yaml
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/bridge/microchip,sam9x75-lvds.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip SAM9X75 LVDS Controller
+
+maintainers:
+ - Dharma Balasubiramani <dharma.b@microchip.com>
+
+description:
+ The Low Voltage Differential Signaling Controller (LVDSC) manages data
+ format conversion from the LCD Controller internal DPI bus to OpenLDI
+ LVDS output signals. LVDSC functions include bit mapping, balanced mode
+ management, and serializer.
+
+properties:
+ compatible:
+ const: microchip,sam9x75-lvds
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: Peripheral Bus Clock
+
+ clock-names:
+ items:
+ - const: pclk
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/clock/at91.h>
+ lvds-controller@f8060000 {
+ compatible = "microchip,sam9x75-lvds";
+ reg = <0xf8060000 0x100>;
+ interrupts = <56 IRQ_TYPE_LEVEL_HIGH 0>;
+ clocks = <&pmc PMC_TYPE_PERIPHERAL 56>;
+ clock-names = "pclk";
+ };
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v8 2/4] drm/bridge: add lvds controller support for sam9x7
2024-04-21 1:10 [PATCH v8 0/4] LVDS Controller Support for SAM9X75 SoC Dharma Balasubiramani
2024-04-21 1:10 ` [PATCH v8 1/4] dt-bindings: display: bridge: add sam9x75-lvds binding Dharma Balasubiramani
@ 2024-04-21 1:10 ` Dharma Balasubiramani
2024-04-21 17:24 ` Dmitry Baryshkov
2024-04-21 1:10 ` [PATCH v8 3/4] MAINTAINERS: add SAM9X7 SoC's LVDS controller Dharma Balasubiramani
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Dharma Balasubiramani @ 2024-04-21 1:10 UTC (permalink / raw
To: dmitry . baryshkov @ linaro . org, andrzej . hajda @ intel . com,
neil . armstrong @ linaro . org, rfoss @ kernel . org,
Laurent . pinchart @ ideasonboard . com, jonas @ kwiboo . se,
jernej . skrabec @ gmail . com,
maarten . lankhorst @ linux . intel . com, mripard @ kernel . org,
tzimmermann @ suse . de, airlied @ gmail . com,
daniel @ ffwll . ch, robh+dt @ kernel . org,
krzysztof . kozlowski+dt @ linaro . org, conor+dt @ kernel . org,
linux @ armlinux . org . uk, Nicolas . Ferre @ microchip . com,
alexandre . belloni @ bootlin . com,
claudiu . beznea @ tuxon . dev, Manikandan . M @ microchip . com,
arnd @ arndb . de, geert+renesas @ glider . be,
Jason @ zx2c4 . com, mpe @ ellerman . id . au,
gerg @ linux-m68k . org, rdunlap @ infradead . org,
vbabka @ suse . cz, dri-devel @ lists . freedesktop . org,
devicetree @ vger . kernel . org,
linux-kernel @ vger . kernel . org,
oe-kbuild-all @ lists . linux . dev,
Hari . PrasathGE @ microchip . com
Cc: Dharma Balasubiramani, Manikandan Muralidharan,
Hari Prasath Gujulan Elango
Add a new LVDS controller driver for sam9x7 which does the following:
- Prepares and enables the LVDS Peripheral clock
- Defines its connector type as DRM_MODE_CONNECTOR_LVDS and adds itself
to the global bridge list.
- Identifies its output endpoint as panel and adds it to the encoder
display pipeline
- Enables the LVDS serializer
Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
Acked-by: Hari Prasath Gujulan Elango <hari.prasathge@microchip.com>
---
Changelog
v7 -> v8
- Assign ret variable properly before checking it for err.
v6 -> v7
- Remove setting encoder type from bridge driver.
- Drop clk_disable() from pm_runtime_get_sync() error handling.
- Use devm_clk_get() instead of prepared version.
- Hence use clk_prepare_enable() and clk_disable_unprepare().
- Use devm_drm_of_get_bridge() instead of devm_drm_panel_bridge_add().
- Add error check for devm_pm_runtime_enable().
- Use dev_err() instead of DRM_DEV_ERROR() as it is deprecated.
- Add missing Acked-by tag.
v5 -> v6
- No Changes.
v4 -> v5
- Drop the unused variable 'format'.
- Use DRM wrapper for dev_err() to maintain uniformity.
- return -ENODEV instead of -EINVAL to maintain consistency with other DRM
bridge drivers.
v3 -> v4
- No changes.
v2 ->v3
- Correct Typo error "serializer".
- Consolidate get() and prepare() functions and use devm_clk_get_prepared().
- Remove unused variable 'ret' in probe().
- Use devm_pm_runtime_enable() and drop the mchp_lvds_remove().
v1 -> v2
- Drop 'res' variable and combine two lines into one.
- Handle deferred probe properly, use dev_err_probe().
- Don't print anything on deferred probe. Dropped print.
- Remove the MODULE_ALIAS and add MODULE_DEVICE_TABLE().
- symbol 'mchp_lvds_driver' was not declared. It should be static.
---
drivers/gpu/drm/bridge/Kconfig | 7 +
drivers/gpu/drm/bridge/Makefile | 1 +
drivers/gpu/drm/bridge/microchip-lvds.c | 229 ++++++++++++++++++++++++
3 files changed, 237 insertions(+)
create mode 100644 drivers/gpu/drm/bridge/microchip-lvds.c
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index efd996f6c138..889098e2d65f 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -190,6 +190,13 @@ config DRM_MEGACHIPS_STDPXXXX_GE_B850V3_FW
to DP++. This is used with the i.MX6 imx-ldb
driver. You are likely to say N here.
+config DRM_MICROCHIP_LVDS_SERIALIZER
+ tristate "Microchip LVDS serializer support"
+ depends on OF
+ depends on DRM_ATMEL_HLCDC
+ help
+ Support for Microchip's LVDS serializer.
+
config DRM_NWL_MIPI_DSI
tristate "Northwest Logic MIPI DSI Host controller"
depends on DRM
diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/Makefile
index 017b5832733b..7df87b582dca 100644
--- a/drivers/gpu/drm/bridge/Makefile
+++ b/drivers/gpu/drm/bridge/Makefile
@@ -13,6 +13,7 @@ obj-$(CONFIG_DRM_LONTIUM_LT9611) += lontium-lt9611.o
obj-$(CONFIG_DRM_LONTIUM_LT9611UXC) += lontium-lt9611uxc.o
obj-$(CONFIG_DRM_LVDS_CODEC) += lvds-codec.o
obj-$(CONFIG_DRM_MEGACHIPS_STDPXXXX_GE_B850V3_FW) += megachips-stdpxxxx-ge-b850v3-fw.o
+obj-$(CONFIG_DRM_MICROCHIP_LVDS_SERIALIZER) += microchip-lvds.o
obj-$(CONFIG_DRM_NXP_PTN3460) += nxp-ptn3460.o
obj-$(CONFIG_DRM_PARADE_PS8622) += parade-ps8622.o
obj-$(CONFIG_DRM_PARADE_PS8640) += parade-ps8640.o
diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
new file mode 100644
index 000000000000..b8313dad6072
--- /dev/null
+++ b/drivers/gpu/drm/bridge/microchip-lvds.c
@@ -0,0 +1,229 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2023 Microchip Technology Inc. and its subsidiaries
+ *
+ * Author: Manikandan Muralidharan <manikandan.m@microchip.com>
+ * Author: Dharma Balasubiramani <dharma.b@microchip.com>
+ *
+ */
+
+#include <linux/clk.h>
+#include <linux/component.h>
+#include <linux/delay.h>
+#include <linux/jiffies.h>
+#include <linux/mfd/syscon.h>
+#include <linux/of_graph.h>
+#include <linux/pinctrl/devinfo.h>
+#include <linux/phy/phy.h>
+#include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <linux/reset.h>
+
+#include <drm/drm_atomic_helper.h>
+#include <drm/drm_bridge.h>
+#include <drm/drm_of.h>
+#include <drm/drm_panel.h>
+#include <drm/drm_print.h>
+#include <drm/drm_probe_helper.h>
+#include <drm/drm_simple_kms_helper.h>
+
+#define LVDS_POLL_TIMEOUT_MS 1000
+
+/* LVDSC register offsets */
+#define LVDSC_CR 0x00
+#define LVDSC_CFGR 0x04
+#define LVDSC_SR 0x0C
+#define LVDSC_WPMR 0xE4
+
+/* Bitfields in LVDSC_CR (Control Register) */
+#define LVDSC_CR_SER_EN BIT(0)
+
+/* Bitfields in LVDSC_CFGR (Configuration Register) */
+#define LVDSC_CFGR_PIXSIZE_24BITS 0
+#define LVDSC_CFGR_DEN_POL_HIGH 0
+#define LVDSC_CFGR_DC_UNBALANCED 0
+#define LVDSC_CFGR_MAPPING_JEIDA BIT(6)
+
+/*Bitfields in LVDSC_SR */
+#define LVDSC_SR_CS BIT(0)
+
+/* Bitfields in LVDSC_WPMR (Write Protection Mode Register) */
+#define LVDSC_WPMR_WPKEY_MASK GENMASK(31, 8)
+#define LVDSC_WPMR_WPKEY_PSSWD 0x4C5644
+
+struct mchp_lvds {
+ struct device *dev;
+ void __iomem *regs;
+ struct clk *pclk;
+ struct drm_panel *panel;
+ struct drm_bridge bridge;
+ struct drm_bridge *panel_bridge;
+};
+
+static inline struct mchp_lvds *bridge_to_lvds(struct drm_bridge *bridge)
+{
+ return container_of(bridge, struct mchp_lvds, bridge);
+}
+
+static inline u32 lvds_readl(struct mchp_lvds *lvds, u32 offset)
+{
+ return readl_relaxed(lvds->regs + offset);
+}
+
+static inline void lvds_writel(struct mchp_lvds *lvds, u32 offset, u32 val)
+{
+ writel_relaxed(val, lvds->regs + offset);
+}
+
+static void lvds_serialiser_on(struct mchp_lvds *lvds)
+{
+ unsigned long timeout = jiffies + msecs_to_jiffies(LVDS_POLL_TIMEOUT_MS);
+
+ /* The LVDSC registers can only be written if WPEN is cleared */
+ lvds_writel(lvds, LVDSC_WPMR, (LVDSC_WPMR_WPKEY_PSSWD &
+ LVDSC_WPMR_WPKEY_MASK));
+
+ /* Wait for the status of configuration registers to be changed */
+ while (lvds_readl(lvds, LVDSC_SR) & LVDSC_SR_CS) {
+ if (time_after(jiffies, timeout)) {
+ dev_err(lvds->dev, "%s: timeout error\n", __func__);
+ return;
+ }
+ usleep_range(1000, 2000);
+ }
+
+ /* Configure the LVDSC */
+ lvds_writel(lvds, LVDSC_CFGR, (LVDSC_CFGR_MAPPING_JEIDA |
+ LVDSC_CFGR_DC_UNBALANCED |
+ LVDSC_CFGR_DEN_POL_HIGH |
+ LVDSC_CFGR_PIXSIZE_24BITS));
+
+ /* Enable the LVDS serializer */
+ lvds_writel(lvds, LVDSC_CR, LVDSC_CR_SER_EN);
+}
+
+static int mchp_lvds_attach(struct drm_bridge *bridge,
+ enum drm_bridge_attach_flags flags)
+{
+ struct mchp_lvds *lvds = bridge_to_lvds(bridge);
+
+ return drm_bridge_attach(bridge->encoder, lvds->panel_bridge,
+ bridge, flags);
+}
+
+static void mchp_lvds_enable(struct drm_bridge *bridge)
+{
+ struct mchp_lvds *lvds = bridge_to_lvds(bridge);
+ int ret;
+
+ ret = clk_prepare_enable(lvds->pclk);
+ if (ret < 0) {
+ dev_err(lvds->dev, "failed to enable lvds pclk %d\n", ret);
+ return;
+ }
+
+ ret = pm_runtime_get_sync(lvds->dev);
+ if (ret < 0) {
+ dev_err(lvds->dev, "failed to get pm runtime: %d\n", ret);
+ return;
+ }
+
+ lvds_serialiser_on(lvds);
+}
+
+static void mchp_lvds_disable(struct drm_bridge *bridge)
+{
+ struct mchp_lvds *lvds = bridge_to_lvds(bridge);
+
+ pm_runtime_put(lvds->dev);
+ clk_disable_unprepare(lvds->pclk);
+}
+
+static const struct drm_bridge_funcs mchp_lvds_bridge_funcs = {
+ .attach = mchp_lvds_attach,
+ .enable = mchp_lvds_enable,
+ .disable = mchp_lvds_disable,
+};
+
+static int mchp_lvds_probe(struct platform_device *pdev)
+{
+ struct device *dev = &pdev->dev;
+ struct mchp_lvds *lvds;
+ struct device_node *port;
+ int ret;
+
+ if (!dev->of_node)
+ return -ENODEV;
+
+ lvds = devm_kzalloc(&pdev->dev, sizeof(*lvds), GFP_KERNEL);
+ if (!lvds)
+ return -ENOMEM;
+
+ lvds->dev = dev;
+
+ lvds->regs = devm_ioremap_resource(lvds->dev,
+ platform_get_resource(pdev, IORESOURCE_MEM, 0));
+ if (IS_ERR(lvds->regs))
+ return PTR_ERR(lvds->regs);
+
+ lvds->pclk = devm_clk_get(lvds->dev, "pclk");
+ if (IS_ERR(lvds->pclk))
+ return dev_err_probe(lvds->dev, PTR_ERR(lvds->pclk),
+ "could not get pclk_lvds\n");
+
+ port = of_graph_get_remote_node(dev->of_node, 1, 0);
+ if (!port) {
+ dev_err(dev,
+ "can't find port point, please init lvds panel port!\n");
+ return -ENODEV;
+ }
+
+ lvds->panel = of_drm_find_panel(port);
+ of_node_put(port);
+
+ if (IS_ERR(lvds->panel))
+ return -EPROBE_DEFER;
+
+ lvds->panel_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0);
+
+ if (IS_ERR(lvds->panel_bridge))
+ return PTR_ERR(lvds->panel_bridge);
+
+ lvds->bridge.of_node = dev->of_node;
+ lvds->bridge.type = DRM_MODE_CONNECTOR_LVDS;
+ lvds->bridge.funcs = &mchp_lvds_bridge_funcs;
+
+ dev_set_drvdata(dev, lvds);
+ ret = devm_pm_runtime_enable(dev);
+ if (ret < 0) {
+ dev_err(lvds->dev, "failed to enable pm runtime: %d\n", ret);
+ return ret;
+ }
+
+ drm_bridge_add(&lvds->bridge);
+
+ return 0;
+}
+
+static const struct of_device_id mchp_lvds_dt_ids[] = {
+ {
+ .compatible = "microchip,sam9x75-lvds",
+ },
+ {},
+};
+MODULE_DEVICE_TABLE(of, mchp_lvds_dt_ids);
+
+static struct platform_driver mchp_lvds_driver = {
+ .probe = mchp_lvds_probe,
+ .driver = {
+ .name = "microchip-lvds",
+ .of_match_table = mchp_lvds_dt_ids,
+ },
+};
+module_platform_driver(mchp_lvds_driver);
+
+MODULE_AUTHOR("Manikandan Muralidharan <manikandan.m@microchip.com>");
+MODULE_AUTHOR("Dharma Balasubiramani <dharma.b@microchip.com>");
+MODULE_DESCRIPTION("Low Voltage Differential Signaling Controller Driver");
+MODULE_LICENSE("GPL");
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v8 3/4] MAINTAINERS: add SAM9X7 SoC's LVDS controller
2024-04-21 1:10 [PATCH v8 0/4] LVDS Controller Support for SAM9X75 SoC Dharma Balasubiramani
2024-04-21 1:10 ` [PATCH v8 1/4] dt-bindings: display: bridge: add sam9x75-lvds binding Dharma Balasubiramani
2024-04-21 1:10 ` [PATCH v8 2/4] drm/bridge: add lvds controller support for sam9x7 Dharma Balasubiramani
@ 2024-04-21 1:10 ` Dharma Balasubiramani
2024-04-21 1:10 ` [PATCH v8 4/4] ARM: configs: at91: Enable LVDS serializer support Dharma Balasubiramani
2024-04-23 7:31 ` (subset) [PATCH v8 0/4] LVDS Controller Support for SAM9X75 SoC Neil Armstrong
4 siblings, 0 replies; 8+ messages in thread
From: Dharma Balasubiramani @ 2024-04-21 1:10 UTC (permalink / raw
To: dmitry . baryshkov @ linaro . org, andrzej . hajda @ intel . com,
neil . armstrong @ linaro . org, rfoss @ kernel . org,
Laurent . pinchart @ ideasonboard . com, jonas @ kwiboo . se,
jernej . skrabec @ gmail . com,
maarten . lankhorst @ linux . intel . com, mripard @ kernel . org,
tzimmermann @ suse . de, airlied @ gmail . com,
daniel @ ffwll . ch, robh+dt @ kernel . org,
krzysztof . kozlowski+dt @ linaro . org, conor+dt @ kernel . org,
linux @ armlinux . org . uk, Nicolas . Ferre @ microchip . com,
alexandre . belloni @ bootlin . com,
claudiu . beznea @ tuxon . dev, Manikandan . M @ microchip . com,
arnd @ arndb . de, geert+renesas @ glider . be,
Jason @ zx2c4 . com, mpe @ ellerman . id . au,
gerg @ linux-m68k . org, rdunlap @ infradead . org,
vbabka @ suse . cz, dri-devel @ lists . freedesktop . org,
devicetree @ vger . kernel . org,
linux-kernel @ vger . kernel . org,
oe-kbuild-all @ lists . linux . dev,
Hari . PrasathGE @ microchip . com
Cc: Dharma Balasubiramani, Nicolas Ferre
Add the newly added LVDS controller for the SAM9X7 SoC to the existing
MAINTAINERS entry.
Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
Changelog
v7 -> v8
v6 -> v7
- No changes.
v5 -> v6
- Correct the file name sam9x7-lvds.yaml -> sam9x75-lvds.yaml.
v4 -> v5
v3 -> v4
- No changes.
v2 -> v3
- Move the entry before "MICROCHIP SAMA5D2-COMPATIBLE ADC DRIVER".
v1 -> v2
- No Changes.
---
MAINTAINERS | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c23fda1aa1f0..e49347eac596 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14563,6 +14563,14 @@ S: Supported
F: Documentation/devicetree/bindings/pwm/atmel,at91sam-pwm.yaml
F: drivers/pwm/pwm-atmel.c
+MICROCHIP SAM9x7-COMPATIBLE LVDS CONTROLLER
+M: Manikandan Muralidharan <manikandan.m@microchip.com>
+M: Dharma Balasubiramani <dharma.b@microchip.com>
+L: dri-devel@lists.freedesktop.org
+S: Supported
+F: Documentation/devicetree/bindings/display/bridge/microchip,sam9x75-lvds.yaml
+F: drivers/gpu/drm/bridge/microchip-lvds.c
+
MICROCHIP SAMA5D2-COMPATIBLE ADC DRIVER
M: Eugen Hristev <eugen.hristev@microchip.com>
L: linux-iio@vger.kernel.org
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v8 4/4] ARM: configs: at91: Enable LVDS serializer support
2024-04-21 1:10 [PATCH v8 0/4] LVDS Controller Support for SAM9X75 SoC Dharma Balasubiramani
` (2 preceding siblings ...)
2024-04-21 1:10 ` [PATCH v8 3/4] MAINTAINERS: add SAM9X7 SoC's LVDS controller Dharma Balasubiramani
@ 2024-04-21 1:10 ` Dharma Balasubiramani
2024-06-09 13:00 ` claudiu beznea
2024-04-23 7:31 ` (subset) [PATCH v8 0/4] LVDS Controller Support for SAM9X75 SoC Neil Armstrong
4 siblings, 1 reply; 8+ messages in thread
From: Dharma Balasubiramani @ 2024-04-21 1:10 UTC (permalink / raw
To: dmitry . baryshkov @ linaro . org, andrzej . hajda @ intel . com,
neil . armstrong @ linaro . org, rfoss @ kernel . org,
Laurent . pinchart @ ideasonboard . com, jonas @ kwiboo . se,
jernej . skrabec @ gmail . com,
maarten . lankhorst @ linux . intel . com, mripard @ kernel . org,
tzimmermann @ suse . de, airlied @ gmail . com,
daniel @ ffwll . ch, robh+dt @ kernel . org,
krzysztof . kozlowski+dt @ linaro . org, conor+dt @ kernel . org,
linux @ armlinux . org . uk, Nicolas . Ferre @ microchip . com,
alexandre . belloni @ bootlin . com,
claudiu . beznea @ tuxon . dev, Manikandan . M @ microchip . com,
arnd @ arndb . de, geert+renesas @ glider . be,
Jason @ zx2c4 . com, mpe @ ellerman . id . au,
gerg @ linux-m68k . org, rdunlap @ infradead . org,
vbabka @ suse . cz, dri-devel @ lists . freedesktop . org,
devicetree @ vger . kernel . org,
linux-kernel @ vger . kernel . org,
oe-kbuild-all @ lists . linux . dev,
Hari . PrasathGE @ microchip . com
Cc: Dharma Balasubiramani, Hari Prasath Gujulan Elango, Nicolas Ferre
Enable LVDS serializer support for display pipeline.
Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
Acked-by: Hari Prasath Gujulan Elango <hari.prasathge@microchip.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
Changelog
v7 -> v8
v6 -> v7
v5 -> v6
v4 -> v5
v3 -> v4
v2 -> v3
- No Changes.
---
arch/arm/configs/at91_dt_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig
index 1d53aec4c836..6eabe2313c9a 100644
--- a/arch/arm/configs/at91_dt_defconfig
+++ b/arch/arm/configs/at91_dt_defconfig
@@ -143,6 +143,7 @@ CONFIG_VIDEO_OV2640=m
CONFIG_VIDEO_OV7740=m
CONFIG_DRM=y
CONFIG_DRM_ATMEL_HLCDC=y
+CONFIG_DRM_MICROCHIP_LVDS_SERIALIZER=y
CONFIG_DRM_PANEL_SIMPLE=y
CONFIG_DRM_PANEL_EDP=y
CONFIG_FB_ATMEL=y
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v8 2/4] drm/bridge: add lvds controller support for sam9x7
2024-04-21 1:10 ` [PATCH v8 2/4] drm/bridge: add lvds controller support for sam9x7 Dharma Balasubiramani
@ 2024-04-21 17:24 ` Dmitry Baryshkov
0 siblings, 0 replies; 8+ messages in thread
From: Dmitry Baryshkov @ 2024-04-21 17:24 UTC (permalink / raw
To: Dharma Balasubiramani
Cc: andrzej . hajda @ intel . com, neil . armstrong @ linaro . org,
rfoss @ kernel . org, Laurent . pinchart @ ideasonboard . com,
jonas @ kwiboo . se, jernej . skrabec @ gmail . com,
maarten . lankhorst @ linux . intel . com, mripard @ kernel . org,
tzimmermann @ suse . de, airlied @ gmail . com,
daniel @ ffwll . ch, robh+dt @ kernel . org,
krzysztof . kozlowski+dt @ linaro . org, conor+dt @ kernel . org,
linux @ armlinux . org . uk, Nicolas . Ferre @ microchip . com,
alexandre . belloni @ bootlin . com,
claudiu . beznea @ tuxon . dev, Manikandan . M @ microchip . com,
arnd @ arndb . de, geert+renesas @ glider . be,
Jason @ zx2c4 . com, mpe @ ellerman . id . au,
gerg @ linux-m68k . org, rdunlap @ infradead . org,
vbabka @ suse . cz, dri-devel @ lists . freedesktop . org,
devicetree @ vger . kernel . org,
linux-kernel @ vger . kernel . org,
oe-kbuild-all @ lists . linux . dev,
Hari . PrasathGE @ microchip . com
On Sun, Apr 21, 2024 at 06:40:48AM +0530, Dharma Balasubiramani wrote:
> Add a new LVDS controller driver for sam9x7 which does the following:
> - Prepares and enables the LVDS Peripheral clock
> - Defines its connector type as DRM_MODE_CONNECTOR_LVDS and adds itself
> to the global bridge list.
> - Identifies its output endpoint as panel and adds it to the encoder
> display pipeline
> - Enables the LVDS serializer
>
> Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
> Acked-by: Hari Prasath Gujulan Elango <hari.prasathge@microchip.com>
> ---
> Changelog
> v7 -> v8
> - Assign ret variable properly before checking it for err.
> v6 -> v7
> - Remove setting encoder type from bridge driver.
> - Drop clk_disable() from pm_runtime_get_sync() error handling.
> - Use devm_clk_get() instead of prepared version.
> - Hence use clk_prepare_enable() and clk_disable_unprepare().
> - Use devm_drm_of_get_bridge() instead of devm_drm_panel_bridge_add().
> - Add error check for devm_pm_runtime_enable().
> - Use dev_err() instead of DRM_DEV_ERROR() as it is deprecated.
> - Add missing Acked-by tag.
> v5 -> v6
> - No Changes.
> v4 -> v5
> - Drop the unused variable 'format'.
> - Use DRM wrapper for dev_err() to maintain uniformity.
> - return -ENODEV instead of -EINVAL to maintain consistency with other DRM
> bridge drivers.
> v3 -> v4
> - No changes.
> v2 ->v3
> - Correct Typo error "serializer".
> - Consolidate get() and prepare() functions and use devm_clk_get_prepared().
> - Remove unused variable 'ret' in probe().
> - Use devm_pm_runtime_enable() and drop the mchp_lvds_remove().
> v1 -> v2
> - Drop 'res' variable and combine two lines into one.
> - Handle deferred probe properly, use dev_err_probe().
> - Don't print anything on deferred probe. Dropped print.
> - Remove the MODULE_ALIAS and add MODULE_DEVICE_TABLE().
> - symbol 'mchp_lvds_driver' was not declared. It should be static.
> ---
> drivers/gpu/drm/bridge/Kconfig | 7 +
> drivers/gpu/drm/bridge/Makefile | 1 +
> drivers/gpu/drm/bridge/microchip-lvds.c | 229 ++++++++++++++++++++++++
> 3 files changed, 237 insertions(+)
> create mode 100644 drivers/gpu/drm/bridge/microchip-lvds.c
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: (subset) [PATCH v8 0/4] LVDS Controller Support for SAM9X75 SoC
2024-04-21 1:10 [PATCH v8 0/4] LVDS Controller Support for SAM9X75 SoC Dharma Balasubiramani
` (3 preceding siblings ...)
2024-04-21 1:10 ` [PATCH v8 4/4] ARM: configs: at91: Enable LVDS serializer support Dharma Balasubiramani
@ 2024-04-23 7:31 ` Neil Armstrong
4 siblings, 0 replies; 8+ messages in thread
From: Neil Armstrong @ 2024-04-23 7:31 UTC (permalink / raw
To: dmitry . baryshkov @ linaro . org, andrzej . hajda @ intel . com,
rfoss @ kernel . org, Laurent . pinchart @ ideasonboard . com,
jonas @ kwiboo . se, jernej . skrabec @ gmail . com,
maarten . lankhorst @ linux . intel . com, mripard @ kernel . org,
tzimmermann @ suse . de, airlied @ gmail . com,
daniel @ ffwll . ch, robh+dt @ kernel . org,
krzysztof . kozlowski+dt @ linaro . org, conor+dt @ kernel . org,
linux @ armlinux . org . uk, Nicolas . Ferre @ microchip . com,
alexandre . belloni @ bootlin . com,
claudiu . beznea @ tuxon . dev, Manikandan . M @ microchip . com,
arnd @ arndb . de, geert+renesas @ glider . be,
Jason @ zx2c4 . com, mpe @ ellerman . id . au,
gerg @ linux-m68k . org, rdunlap @ infradead . org,
vbabka @ suse . cz, dri-devel @ lists . freedesktop . org,
devicetree @ vger . kernel . org,
linux-kernel @ vger . kernel . org,
oe-kbuild-all @ lists . linux . dev,
Hari . PrasathGE @ microchip . com, Dharma Balasubiramani
Hi,
On Sun, 21 Apr 2024 06:40:46 +0530, Dharma Balasubiramani wrote:
> This patch series introduces LVDS controller support for the SAM9X75 SoC. The
> LVDS controller is designed to work with Microchip's sam9x7 series
> System-on-Chip (SoC) devices, providing Low Voltage Differential Signaling
> capabilities.
>
> Patch series Changelog:
> - Include configs: at91: Enable LVDS serializer
> - include all necessary To/Cc entries.
> The Individual Changelogs are available on the respective patches.
>
> [...]
Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)
[1/4] dt-bindings: display: bridge: add sam9x75-lvds binding
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/c24177ca3b27e5a7ddaab8d330cedecd7eb9244a
[2/4] drm/bridge: add lvds controller support for sam9x7
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/179b0769fc5fc193d7837bdcb6ddee118a0fa9b8
[3/4] MAINTAINERS: add SAM9X7 SoC's LVDS controller
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/e95752752eaf06c860811ac5ddf9badf6c1b43ca
--
Neil
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v8 4/4] ARM: configs: at91: Enable LVDS serializer support
2024-04-21 1:10 ` [PATCH v8 4/4] ARM: configs: at91: Enable LVDS serializer support Dharma Balasubiramani
@ 2024-06-09 13:00 ` claudiu beznea
0 siblings, 0 replies; 8+ messages in thread
From: claudiu beznea @ 2024-06-09 13:00 UTC (permalink / raw
To: Dharma Balasubiramani, dmitry . baryshkov @ linaro . org,
andrzej . hajda @ intel . com, neil . armstrong @ linaro . org,
rfoss @ kernel . org, Laurent . pinchart @ ideasonboard . com,
jonas @ kwiboo . se, jernej . skrabec @ gmail . com,
maarten . lankhorst @ linux . intel . com, mripard @ kernel . org,
tzimmermann @ suse . de, airlied @ gmail . com,
daniel @ ffwll . ch, robh+dt @ kernel . org,
krzysztof . kozlowski+dt @ linaro . org, conor+dt @ kernel . org,
linux @ armlinux . org . uk, Nicolas . Ferre @ microchip . com,
alexandre . belloni @ bootlin . com,
Manikandan . M @ microchip . com, arnd @ arndb . de,
geert+renesas @ glider . be, Jason @ zx2c4 . com,
mpe @ ellerman . id . au, gerg @ linux-m68k . org,
rdunlap @ infradead . org, vbabka @ suse . cz,
dri-devel @ lists . freedesktop . org,
devicetree @ vger . kernel . org,
linux-kernel @ vger . kernel . org,
oe-kbuild-all @ lists . linux . dev,
Hari . PrasathGE @ microchip . com
On 21.04.2024 04:10, Dharma Balasubiramani wrote:
> Enable LVDS serializer support for display pipeline.
>
> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
> Acked-by: Hari Prasath Gujulan Elango <hari.prasathge@microchip.com>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Applied to at91-defconfig, thanks!
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-06-09 13:00 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-21 1:10 [PATCH v8 0/4] LVDS Controller Support for SAM9X75 SoC Dharma Balasubiramani
2024-04-21 1:10 ` [PATCH v8 1/4] dt-bindings: display: bridge: add sam9x75-lvds binding Dharma Balasubiramani
2024-04-21 1:10 ` [PATCH v8 2/4] drm/bridge: add lvds controller support for sam9x7 Dharma Balasubiramani
2024-04-21 17:24 ` Dmitry Baryshkov
2024-04-21 1:10 ` [PATCH v8 3/4] MAINTAINERS: add SAM9X7 SoC's LVDS controller Dharma Balasubiramani
2024-04-21 1:10 ` [PATCH v8 4/4] ARM: configs: at91: Enable LVDS serializer support Dharma Balasubiramani
2024-06-09 13:00 ` claudiu beznea
2024-04-23 7:31 ` (subset) [PATCH v8 0/4] LVDS Controller Support for SAM9X75 SoC Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).