* Re: [PATCH v2 2/5] mm: zswap: calculate limits only when updated
[not found] <20240405053510.1948982-3-yosryahmed@google.com>
@ 2024-04-05 20:23 ` kernel test robot
2024-04-05 20:29 ` Yosry Ahmed
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2024-04-05 20:23 UTC (permalink / raw
To: Yosry Ahmed, Andrew Morton
Cc: oe-kbuild-all, Linux Memory Management List, Johannes Weiner,
Nhat Pham, Chengming Zhou, linux-kernel, Yosry Ahmed
Hi Yosry,
kernel test robot noticed the following build warnings:
[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on next-20240405]
[cannot apply to linus/master v6.9-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-zswap-always-shrink-in-zswap_store-if-zswap_pool_reached_full/20240405-133623
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20240405053510.1948982-3-yosryahmed%40google.com
patch subject: [PATCH v2 2/5] mm: zswap: calculate limits only when updated
config: i386-randconfig-061-20240405 (https://download.01.org/0day-ci/archive/20240406/202404060445.zMPxumi9-lkp@intel.com/config)
compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240406/202404060445.zMPxumi9-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404060445.zMPxumi9-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> mm/zswap.c:132:15: sparse: sparse: symbol 'zswap_accept_thr_pages' was not declared. Should it be static?
mm/zswap.c:1188:23: sparse: sparse: context imbalance in 'shrink_memcg_cb' - unexpected unlock
vim +/zswap_accept_thr_pages +132 mm/zswap.c
120
121 static int zswap_max_pool_param_set(const char *,
122 const struct kernel_param *);
123 static const struct kernel_param_ops zswap_max_pool_param_ops = {
124 .set = zswap_max_pool_param_set,
125 .get = param_get_uint,
126 };
127 module_param_cb(max_pool_percent, &zswap_max_pool_param_ops,
128 &zswap_max_pool_percent, 0644);
129
130 /* The threshold for accepting new pages after the max_pool_percent was hit */
131 static unsigned int zswap_accept_thr_percent = 90; /* of max pool size */
> 132 unsigned long zswap_accept_thr_pages;
133
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 2/5] mm: zswap: calculate limits only when updated
2024-04-05 20:23 ` [PATCH v2 2/5] mm: zswap: calculate limits only when updated kernel test robot
@ 2024-04-05 20:29 ` Yosry Ahmed
0 siblings, 0 replies; 2+ messages in thread
From: Yosry Ahmed @ 2024-04-05 20:29 UTC (permalink / raw
To: kernel test robot
Cc: Andrew Morton, oe-kbuild-all, Linux Memory Management List,
Johannes Weiner, Nhat Pham, Chengming Zhou, linux-kernel
On Fri, Apr 5, 2024 at 1:24 PM kernel test robot <lkp@intel.com> wrote:
>
> Hi Yosry,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on akpm-mm/mm-everything]
> [also build test WARNING on next-20240405]
> [cannot apply to linus/master v6.9-rc2]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-zswap-always-shrink-in-zswap_store-if-zswap_pool_reached_full/20240405-133623
> base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
> patch link: https://lore.kernel.org/r/20240405053510.1948982-3-yosryahmed%40google.com
> patch subject: [PATCH v2 2/5] mm: zswap: calculate limits only when updated
> config: i386-randconfig-061-20240405 (https://download.01.org/0day-ci/archive/20240406/202404060445.zMPxumi9-lkp@intel.com/config)
> compiler: gcc-10 (Ubuntu 10.5.0-1ubuntu1) 10.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240406/202404060445.zMPxumi9-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202404060445.zMPxumi9-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
> >> mm/zswap.c:132:15: sparse: sparse: symbol 'zswap_accept_thr_pages' was not declared. Should it be static?
Yes, I already have it static for v3, which will be sent after the
discussion on this patch settles.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-05 20:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240405053510.1948982-3-yosryahmed@google.com>
2024-04-05 20:23 ` [PATCH v2 2/5] mm: zswap: calculate limits only when updated kernel test robot
2024-04-05 20:29 ` Yosry Ahmed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).