* [palmer:for-next 27/30] arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask'
@ 2024-04-17 22:14 kernel test robot
2024-04-17 23:51 ` Charlie Jenkins
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2024-04-17 22:14 UTC (permalink / raw
To: Charlie Jenkins
Cc: oe-kbuild-all, Palmer Dabbelt, Atish Patra, Alexandre Ghiti,
Samuel Holland
tree: https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git for-next
head: a76716f0ec75b9e7ac62d30854d690044c857684
commit: 383289e4b071ca4c8c42e34567f3f267766f093c [27/30] riscv: Include riscv_set_icache_flush_ctx prctl
config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20240418/202404180621.qG7A9Tk0-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240418/202404180621.qG7A9Tk0-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404180621.qG7A9Tk0-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
arch/riscv/mm/cacheflush.c: In function 'set_icache_stale_mask':
>> arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask'
168 | mask = ¤t->mm->context.icache_stale_mask;
| ^
arch/riscv/mm/cacheflush.c: At top level:
>> arch/riscv/mm/cacheflush.c:157:13: warning: 'set_icache_stale_mask' defined but not used [-Wunused-function]
157 | static void set_icache_stale_mask(void)
| ^~~~~~~~~~~~~~~~~~~~~
vim +168 arch/riscv/mm/cacheflush.c
156
> 157 static void set_icache_stale_mask(void)
158 {
159 cpumask_t *mask;
160 bool stale_cpu;
161
162 /*
163 * Mark every other hart's icache as needing a flush for
164 * this MM. Maintain the previous value of the current
165 * cpu to handle the case when this function is called
166 * concurrently on different harts.
167 */
> 168 mask = ¤t->mm->context.icache_stale_mask;
169 stale_cpu = cpumask_test_cpu(smp_processor_id(), mask);
170
171 cpumask_setall(mask);
172 assign_bit(cpumask_check(smp_processor_id()), cpumask_bits(mask), stale_cpu);
173 }
174
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [palmer:for-next 27/30] arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask'
2024-04-17 22:14 [palmer:for-next 27/30] arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask' kernel test robot
@ 2024-04-17 23:51 ` Charlie Jenkins
2024-04-18 15:12 ` Palmer Dabbelt
0 siblings, 1 reply; 3+ messages in thread
From: Charlie Jenkins @ 2024-04-17 23:51 UTC (permalink / raw
To: kernel test robot
Cc: oe-kbuild-all, Palmer Dabbelt, Atish Patra, Alexandre Ghiti,
Samuel Holland
On Thu, Apr 18, 2024 at 06:14:34AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git for-next
> head: a76716f0ec75b9e7ac62d30854d690044c857684
> commit: 383289e4b071ca4c8c42e34567f3f267766f093c [27/30] riscv: Include riscv_set_icache_flush_ctx prctl
> config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20240418/202404180621.qG7A9Tk0-lkp@intel.com/config)
> compiler: riscv64-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240418/202404180621.qG7A9Tk0-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202404180621.qG7A9Tk0-lkp@intel.com/
>
> All error/warnings (new ones prefixed by >>):
>
> arch/riscv/mm/cacheflush.c: In function 'set_icache_stale_mask':
> >> arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask'
> 168 | mask = ¤t->mm->context.icache_stale_mask;
> | ^
> arch/riscv/mm/cacheflush.c: At top level:
> >> arch/riscv/mm/cacheflush.c:157:13: warning: 'set_icache_stale_mask' defined but not used [-Wunused-function]
> 157 | static void set_icache_stale_mask(void)
> | ^~~~~~~~~~~~~~~~~~~~~
>
>
> vim +168 arch/riscv/mm/cacheflush.c
>
> 156
> > 157 static void set_icache_stale_mask(void)
> 158 {
> 159 cpumask_t *mask;
> 160 bool stale_cpu;
> 161
> 162 /*
> 163 * Mark every other hart's icache as needing a flush for
> 164 * this MM. Maintain the previous value of the current
> 165 * cpu to handle the case when this function is called
> 166 * concurrently on different harts.
> 167 */
> > 168 mask = ¤t->mm->context.icache_stale_mask;
> 169 stale_cpu = cpumask_test_cpu(smp_processor_id(), mask);
> 170
> 171 cpumask_setall(mask);
> 172 assign_bit(cpumask_check(smp_processor_id()), cpumask_bits(mask), stale_cpu);
> 173 }
> 174
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
I thought I tested this... Simple fix though, just need to guard this
function with CONFIG_SMP
https://lore.kernel.org/lkml/20240417-fix_nosmp_icache-v1-1-921a3c07d4ce@rivosinc.com/T/#u.
- Charlie
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [palmer:for-next 27/30] arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask'
2024-04-17 23:51 ` Charlie Jenkins
@ 2024-04-18 15:12 ` Palmer Dabbelt
0 siblings, 0 replies; 3+ messages in thread
From: Palmer Dabbelt @ 2024-04-18 15:12 UTC (permalink / raw
To: Charlie Jenkins
Cc: lkp, oe-kbuild-all, Atish Patra, alexghiti, samuel.holland
On Wed, 17 Apr 2024 16:51:22 PDT (-0700), Charlie Jenkins wrote:
> On Thu, Apr 18, 2024 at 06:14:34AM +0800, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/palmer/linux.git for-next
>> head: a76716f0ec75b9e7ac62d30854d690044c857684
>> commit: 383289e4b071ca4c8c42e34567f3f267766f093c [27/30] riscv: Include riscv_set_icache_flush_ctx prctl
>> config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20240418/202404180621.qG7A9Tk0-lkp@intel.com/config)
>> compiler: riscv64-linux-gcc (GCC) 13.2.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240418/202404180621.qG7A9Tk0-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202404180621.qG7A9Tk0-lkp@intel.com/
>>
>> All error/warnings (new ones prefixed by >>):
>>
>> arch/riscv/mm/cacheflush.c: In function 'set_icache_stale_mask':
>> >> arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask'
>> 168 | mask = ¤t->mm->context.icache_stale_mask;
>> | ^
>> arch/riscv/mm/cacheflush.c: At top level:
>> >> arch/riscv/mm/cacheflush.c:157:13: warning: 'set_icache_stale_mask' defined but not used [-Wunused-function]
>> 157 | static void set_icache_stale_mask(void)
>> | ^~~~~~~~~~~~~~~~~~~~~
>>
>>
>> vim +168 arch/riscv/mm/cacheflush.c
>>
>> 156
>> > 157 static void set_icache_stale_mask(void)
>> 158 {
>> 159 cpumask_t *mask;
>> 160 bool stale_cpu;
>> 161
>> 162 /*
>> 163 * Mark every other hart's icache as needing a flush for
>> 164 * this MM. Maintain the previous value of the current
>> 165 * cpu to handle the case when this function is called
>> 166 * concurrently on different harts.
>> 167 */
>> > 168 mask = ¤t->mm->context.icache_stale_mask;
>> 169 stale_cpu = cpumask_test_cpu(smp_processor_id(), mask);
>> 170
>> 171 cpumask_setall(mask);
>> 172 assign_bit(cpumask_check(smp_processor_id()), cpumask_bits(mask), stale_cpu);
>> 173 }
>> 174
>>
>> --
>> 0-DAY CI Kernel Test Service
>> https://github.com/intel/lkp-tests/wiki
>
> I thought I tested this... Simple fix though, just need to guard this
> function with CONFIG_SMP
> https://lore.kernel.org/lkml/20240417-fix_nosmp_icache-v1-1-921a3c07d4ce@rivosinc.com/T/#u.
Thanks. This hasn't landed in for-next yet, so I'm just going to squash
it into the offending patch.
>
> - Charlie
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-18 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-17 22:14 [palmer:for-next 27/30] arch/riscv/mm/cacheflush.c:168:37: error: 'mm_context_t' has no member named 'icache_stale_mask' kernel test robot
2024-04-17 23:51 ` Charlie Jenkins
2024-04-18 15:12 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).