From: patchwork-bot+ofono@kernel.org
To: Steve Schrock <steve.schrock@getcruise.com>
Cc: ofono@lists.linux.dev
Subject: Re: [PATCH] qmi: Initialize group_id for control requests
Date: Tue, 19 Mar 2024 16:50:28 +0000 [thread overview]
Message-ID: <171086702815.19628.67674889698835829.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240319160639.42456-1-steve.schrock@getcruise.com>
Hello:
This patch was applied to ofono.git (master)
by Denis Kenzior <denkenz@gmail.com>:
On Tue, 19 Mar 2024 16:06:39 +0000 you wrote:
> valgrind found that for control requests, the group_id was not being
> set. The requests are being allocated using l_malloc which does not
> initialize memory to 0, unlike l_new. The impact is that cleanup of
> the requests during service closure or modem shutdown might
> incorrectly remove a control request from the queue. The fix is to
> always initialize this field to 0.
>
> [...]
Here is the summary with links:
- qmi: Initialize group_id for control requests
https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=32f570c95930
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-03-19 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 16:06 [PATCH] qmi: Initialize group_id for control requests Steve Schrock
2024-03-19 16:50 ` patchwork-bot+ofono [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171086702815.19628.67674889698835829.git-patchwork-notify@kernel.org \
--to=patchwork-bot+ofono@kernel.org \
--cc=ofono@lists.linux.dev \
--cc=steve.schrock@getcruise.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).