From: patchwork-bot+ofono@kernel.org
To: Denis Kenzior <denkenz@gmail.com>
Cc: ofono@lists.linux.dev
Subject: Re: [PATCH 1/6] qmi: lte: Remove magic number use
Date: Mon, 29 Apr 2024 19:10:31 +0000 [thread overview]
Message-ID: <171441783155.15158.4319549851895769084.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240429155726.51479-1-denkenz@gmail.com>
Hello:
This series was applied to ofono.git (master)
by Denis Kenzior <denkenz@gmail.com>:
On Mon, 29 Apr 2024 10:56:53 -0500 you wrote:
> Several commands were invoked using magic numbers, even though they're
> defined inside wds.h. Remove magic numbers from enumerations by
> introducing appropriate enums to wds.h. Similarly, use defined
> constants for parameter and result ids.
> ---
> drivers/qmimodem/lte.c | 29 +++++++++++++++--------------
> drivers/qmimodem/wds.h | 14 +++++++++++++-
> 2 files changed, 28 insertions(+), 15 deletions(-)
Here is the summary with links:
- [1/6] qmi: lte: Remove magic number use
https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=758a6ea7faed
- [2/6] qmi: wds: Move enum conversion into wds.c
https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=e1756a883d8a
- [3/6] qmi: lte: Support additional attributes
https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=901835d0f265
- [4/6] qmi: gprs: Query default profile number at init
https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=63a6b34de475
- [5/6] udevng: Add "option" module managed ports to gobi driver
https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=cb4f0876de81
- [6/6] udevng: Support Quectel RM502Q
https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=8254e8ff1553
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-04-29 19:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 15:56 [PATCH 1/6] qmi: lte: Remove magic number use Denis Kenzior
2024-04-29 15:56 ` [PATCH 2/6] qmi: wds: Move enum conversion into wds.c Denis Kenzior
2024-04-29 15:56 ` [PATCH 3/6] qmi: lte: Support additional attributes Denis Kenzior
2024-04-29 15:56 ` [PATCH 4/6] qmi: gprs: Query default profile number at init Denis Kenzior
2024-04-29 15:56 ` [PATCH 5/6] udevng: Add "option" module managed ports to gobi driver Denis Kenzior
2024-04-29 15:56 ` [PATCH 6/6] udevng: Support Quectel RM502Q Denis Kenzior
2024-04-29 19:10 ` patchwork-bot+ofono [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171441783155.15158.4319549851895769084.git-patchwork-notify@kernel.org \
--to=patchwork-bot+ofono@kernel.org \
--cc=denkenz@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).