From: Denis Kenzior <denkenz@gmail.com>
To: "Martin Hundebøll" <martin@geanix.com>, ofono@lists.linux.dev
Cc: MaxLyubimov <m.lyubimov@aqsi.ru>
Subject: Re: [PATCH 03/10] sim7100: query device model during enable
Date: Thu, 2 May 2024 09:04:10 -0500 [thread overview]
Message-ID: <1dff212d-a996-4782-841f-9811a75b7a00@gmail.com> (raw)
In-Reply-To: <20240430115234.180185-3-martin@geanix.com>
Hi Martin,
On 4/30/24 6:52 AM, Martin Hundebøll wrote:
> Adding support for more simcom modems in the sim7100 driver requires
> certain variants handlings based on the present modem model.
>
> Default to an "unknown" variant to keep the existing behaviour, and
> introduce the A76XX model to use when later adding support for the A7672
> vartiant.
> ---
> plugins/sim7100.c | 43 ++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 40 insertions(+), 3 deletions(-)
>
Nice series! Thanks you. This patch was applied as well:
> +
> + if (!ok) {
> + ofono_error("%s: failed to query model", ofono_modem_get_path(modem));
I amended here to avoid > 80 char line.
> + ofono_modem_set_powered(modem, FALSE);
> + return;
> + }
Regards,
-Denis
next prev parent reply other threads:[~2024-05-02 14:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 11:52 [PATCH 01/10] sim7100: simplify serial device opening Martin Hundebøll
2024-04-30 11:52 ` [PATCH 02/10] sim7100: wait for modem to start while enabling Martin Hundebøll
2024-04-30 11:52 ` [PATCH 03/10] sim7100: query device model during enable Martin Hundebøll
2024-05-02 14:04 ` Denis Kenzior [this message]
2024-04-30 11:52 ` [PATCH 04/10] sim7100: implement set_online() Martin Hundebøll
2024-04-30 11:52 ` [PATCH 05/10] sim7100: fix going offline for A76XX modems Martin Hundebøll
2024-04-30 11:52 ` [PATCH 06/10] atmodem: introduce SIMCom A76XX vendor quirks Martin Hundebøll
2024-04-30 11:52 ` [PATCH 07/10] sim7100: enable A76XX simcom vendor quirks for relevant atoms Martin Hundebøll
2024-04-30 11:52 ` [PATCH 08/10] udevng: register support for SIMCom A76XX USB serial modem Martin Hundebøll
2024-05-22 7:48 ` Martin Hundebøll
2024-05-23 13:26 ` Martin Hundebøll
2024-04-30 11:52 ` [PATCH 09/10] Makefile: enable build of simcommodem radiosettings Martin Hundebøll
2024-04-30 11:52 ` [PATCH 10/10] sim7100: create radio-settings atom for A76XX modems Martin Hundebøll
2024-05-02 14:00 ` [PATCH 01/10] sim7100: simplify serial device opening patchwork-bot+ofono
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dff212d-a996-4782-841f-9811a75b7a00@gmail.com \
--to=denkenz@gmail.com \
--cc=m.lyubimov@aqsi.ru \
--cc=martin@geanix.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).