From: Denis Kenzior <denkenz@gmail.com>
To: ofono@lists.linux.dev
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH 6/6] qmi: gprs: Obtain LTE attach parameters after indication
Date: Wed, 1 May 2024 15:51:27 -0500 [thread overview]
Message-ID: <20240501205142.12777-6-denkenz@gmail.com> (raw)
In-Reply-To: <20240501205142.12777-1-denkenz@gmail.com>
It seems this TLV/Indication combination is needed in order for the
GET_LTE_ATTACH_PARAMETERS command to succeed:
ofonod[3257238]: Failed to query LTE attach params: 74
ofonod[3257238]: LTE bearer established but APN not set
---
drivers/qmimodem/gprs.c | 36 +++++++++++++++++++++++-------------
1 file changed, 23 insertions(+), 13 deletions(-)
diff --git a/drivers/qmimodem/gprs.c b/drivers/qmimodem/gprs.c
index 8329f56a2ba8..662fea41fc2f 100644
--- a/drivers/qmimodem/gprs.c
+++ b/drivers/qmimodem/gprs.c
@@ -151,19 +151,6 @@ static int handle_ss_info(struct qmi_result *result, struct ofono_gprs *gprs)
if (!extract_ss_info(result, &status, &tech))
return -1;
- if (status == NETWORK_REGISTRATION_STATUS_REGISTERED) {
- if (tech == ACCESS_TECHNOLOGY_EUTRAN) {
- /* On LTE we are effectively always attached; and
- * the default bearer is established as soon as the
- * network is joined. We just need to query the
- * parameters in effect on the default bearer and
- * let the ofono core know about the activated
- * context.
- */
- get_lte_attach_params(gprs);
- }
- }
-
/* DC is optional so only notify on successful extraction */
if (extract_dc_info(result, &bearer_tech))
ofono_gprs_bearer_notify(gprs, bearer_tech);
@@ -186,8 +173,31 @@ static void ss_info_notify(struct qmi_result *result, void *user_data)
static void event_report_notify(struct qmi_result *result, void *user_data)
{
+ static const uint8_t RESULT_DATA_SYSTEM_STATUS = 0x24;
+ struct ofono_gprs *gprs = user_data;
+ const void *tlv;
+ uint16_t len;
+
DBG("");
+ /*
+ * On LTE we are effectively always attached; and the default bearer is
+ * established as soon as the network is joined. We just need to query
+ * the parameters in effect on the default bearer and let the ofono core
+ * know about the activated context.
+ */
+ tlv = qmi_result_get(result, RESULT_DATA_SYSTEM_STATUS, &len);
+ if (tlv) {
+ int r = qmi_wds_parse_data_system_status(tlv, len);
+ static const uint32_t lte_5g = QMI_WDS_RAT_3GPP_LTE |
+ QMI_WDS_RAT_3GPP_5GNR;
+
+ if (r >= 0 && (r & lte_5g))
+ get_lte_attach_params(gprs);
+
+ return;
+ }
+
qmi_result_print_tlvs(result);
}
--
2.44.0
prev parent reply other threads:[~2024-05-01 20:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 20:51 [PATCH 1/6] qmi: gprs: register to NAS indications earlier Denis Kenzior
2024-05-01 20:51 ` [PATCH 2/6] qmi: gprs: Split out GET_DEFAULT_PROFILE_NUMBER request Denis Kenzior
2024-05-01 20:51 ` [PATCH 3/6] qmi: gprs: register and listen to event reports Denis Kenzior
2024-05-01 20:51 ` [PATCH 4/6] qmi: gprs: Register for other notifications Denis Kenzior
2024-05-01 20:51 ` [PATCH 5/6] qmi: wds: add utility to parse Data System Status tlv Denis Kenzior
2024-05-01 20:51 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501205142.12777-6-denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).