From: Alexandru Ardelean <alex@shruggie.ro>
To: Denis Kenzior <denkenz@gmail.com>
Cc: ofono@lists.linux.dev, patrick.frick@stihl.de,
matthias.gruhler@stihl.de, mircea.caprioru@flowkernel.ro,
stephanie.altenburg@stihl.de
Subject: Re: [RESEND PATCH 3/5] gprs: extend on_lte() to check for M1 and Nb-IOT techs
Date: Fri, 17 Feb 2023 19:04:40 +0200 [thread overview]
Message-ID: <CAH3L5QpifTqU+UL6ic88YZ=yjuqc9u5_MbOn65Sbon2ENcyD7g@mail.gmail.com> (raw)
In-Reply-To: <849beb97-9939-ae1d-a6e8-24dd66097ada@gmail.com>
On Mon, Feb 13, 2023 at 6:52 PM Denis Kenzior <denkenz@gmail.com> wrote:
>
> Hi Alexandru,
>
> On 2/11/23 12:11, Alexandru Ardelean wrote:
> > The BG95 is an LTE modem with Cat M1 and NB-IoT techs.
> > So, when it happens that the modem registers to one of these techs (in our
> > case Cat M1), and there is no GSM advertised by the operator, the modem
> > will not attach.
> >
>
> oFono doesn't really grok these technology types. It must be taught to handle
> them properly.
Ack.
It's what we want to do.
>
> > Following the current logic of LTE, it looks like we just need to extend
> > the "on_lte()" function to allow for these techs.
>
> Or maybe treat them specially if they're not handled like LTE?
Ah.
So, I may be a bit confused here about what LTE refers to (or which
you are referring to).
To me LTE is EUTRAN, Cat M1 and NB-IoT.
But maybe, you are referring to LTE as just EUTRAN, and the others are
specific cases that need to be handled differently.
That is fine from my side.
>
> >
> > Also, not checking the .read_settings callback existence. That looks like a
> > hack done for EUTRAN. In our case, the BG95 is controlled by AT commands,
> > so there is no .read_settings hook yet, and we don't seem to need it.
>
> For LTE support, .read_settings must be implemented. That is because you need
> to obtain the default context details (see my reply to the previous patch).
> This is needed for matching default context to provisioned ones, etc.
Will see maybe about this .read_settings hook.
Maybe we treat LTE Cat M1 entirely differently.
Who knows?
But if we do get QMI to work (at some point), then this is not required anymore.
>
> If NB_IOT* acts differently than LTE in this regard, then modifying on_lte() is
> probably not the right approach.
Hmmm.
So we don't use NB-IoT. It's a requirement (for us) to disable it.
We're just using LTE Cat M1.
I guess I put it there inertially after looking into the list of LTE enums.
>
> > ---
> > src/gprs.c | 16 ++++++++++++----
> > 1 file changed, 12 insertions(+), 4 deletions(-)
> >
>
> Regards,
> -Denis
>
next prev parent reply other threads:[~2023-02-17 17:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-11 18:11 [RESEND PATCH 0/5] quectel: add support for BG95 Alexandru Ardelean
2023-02-11 18:11 ` [RESEND PATCH 1/5] atmodem: gprs-context: fix ATD99 init for modems with no slave channel Alexandru Ardelean
2023-02-13 16:27 ` Denis Kenzior
2023-02-14 8:54 ` Alexandru Ardelean
2023-02-17 7:25 ` Alexandru Ardelean
2023-02-17 15:17 ` Denis Kenzior
2023-02-17 16:50 ` Alexandru Ardelean
2023-02-11 18:11 ` [RESEND PATCH 2/5] gprs: rework have_active_contexts() to check for non-active contexts Alexandru Ardelean
2023-02-13 16:46 ` Denis Kenzior
2023-02-17 15:03 ` Alexandru Ardelean
2023-02-17 15:22 ` Denis Kenzior
2023-02-17 16:51 ` Alexandru Ardelean
2023-02-11 18:11 ` [RESEND PATCH 3/5] gprs: extend on_lte() to check for M1 and Nb-IOT techs Alexandru Ardelean
2023-02-13 16:52 ` Denis Kenzior
2023-02-17 17:04 ` Alexandru Ardelean [this message]
2023-02-11 18:11 ` [RESEND PATCH 4/5] plugins: quectel: re-organize code for ussd & lte init Alexandru Ardelean
2023-02-13 17:07 ` Denis Kenzior
2023-02-11 18:11 ` [RESEND PATCH 5/5] quectel: add support for BG95 Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH3L5QpifTqU+UL6ic88YZ=yjuqc9u5_MbOn65Sbon2ENcyD7g@mail.gmail.com' \
--to=alex@shruggie.ro \
--cc=denkenz@gmail.com \
--cc=matthias.gruhler@stihl.de \
--cc=mircea.caprioru@flowkernel.ro \
--cc=ofono@lists.linux.dev \
--cc=patrick.frick@stihl.de \
--cc=stephanie.altenburg@stihl.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).