From: Andrew Geissler <geissonator@gmail.com>
To: minyard@acm.org, joel@jms.id.au, andrew@codeconstruct.com.au,
openipmi-developer@lists.sourceforge.net,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: openbmc@lists.ozlabs.org, Andrew Geissler <geissonator@yahoo.com>
Subject: [PATCH] ipmi: kcs: Update OBF poll timeout to reduce latency
Date: Tue, 20 Feb 2024 06:36:15 -0600 [thread overview]
Message-ID: <20240220123615.963916-1-geissonator@gmail.com> (raw)
From: Andrew Geissler <geissonator@yahoo.com>
Commit f90bc0f97f2b ("ipmi: kcs: Poll OBF briefly to reduce OBE
latency") introduced an optimization to poll when the host has
read the output data register (ODR). Testing has shown that the 100us
timeout was not always enough. When we miss that 100us window, it
results in 10x the time to get the next message from the BMC to the
host. When you're sending 100's of messages between the BMC and Host,
this results in a server boot taking 50% longer for IBM P10 machines.
Started with 1000 and worked it down until the issue started to reoccur.
200 was the sweet spot in my testing. 150 showed the issue
intermittently.
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
---
drivers/char/ipmi/kcs_bmc_aspeed.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c
index 72640da55380..af1eae6153f6 100644
--- a/drivers/char/ipmi/kcs_bmc_aspeed.c
+++ b/drivers/char/ipmi/kcs_bmc_aspeed.c
@@ -422,7 +422,7 @@ static void aspeed_kcs_irq_mask_update(struct kcs_bmc_device *kcs_bmc, u8 mask,
* missed the event.
*/
rc = read_poll_timeout_atomic(aspeed_kcs_inb, str,
- !(str & KCS_BMC_STR_OBF), 1, 100, false,
+ !(str & KCS_BMC_STR_OBF), 1, 200, false,
&priv->kcs_bmc, priv->kcs_bmc.ioreg.str);
/* Time for the slow path? */
if (rc == -ETIMEDOUT)
--
2.39.2
next reply other threads:[~2024-02-20 15:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 12:36 Andrew Geissler [this message]
2024-02-20 15:51 ` [PATCH] ipmi: kcs: Update OBF poll timeout to reduce latency Paul Menzel
2024-02-20 19:33 ` Corey Minyard
2024-02-20 22:36 ` Andrew Jeffery
2024-02-21 16:57 ` Andrew Geissler
2024-02-21 18:08 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240220123615.963916-1-geissonator@gmail.com \
--to=geissonator@gmail.com \
--cc=andrew@codeconstruct.com.au \
--cc=geissonator@yahoo.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openbmc@lists.ozlabs.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).