From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Supreeth Venkatesh <supreeth.venkatesh@amd.com>,
joel@jms.id.au, andrew@aj.id.au, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org, robh+dt@kernel.org
Subject: Re: [PATCH 1/1] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform
Date: Mon, 26 Feb 2024 17:25:03 +1030 [thread overview]
Message-ID: <572d53516dee6db5af7089090056185abb4e78c7.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240110033543.799919-1-supreeth.venkatesh@amd.com>
On Tue, 2024-01-09 at 21:35 -0600, Supreeth Venkatesh wrote:
> This patch adds initial device tree and makefile updates for
> AMD Onyx platform.
>
> AMD Onyx platform is an AMD customer reference board with an Aspeed
> ast2600 BMC manufactured by AMD.
> It describes I2c devices, Fans, Kcs devices, Uarts, Mac, LEDs, etc.
> present on AMD Onyx platform.
>
> Signed-off-by: Supreeth Venkatesh <supreeth.venkatesh@amd.com>
> ---
> arch/arm/boot/dts/aspeed/Makefile | 1 +
> .../boot/dts/aspeed/aspeed-bmc-amd-onyx.dts | 98 +++++++++++++++++++
> 2 files changed, 99 insertions(+)
> create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts
>
> diff --git a/arch/arm/boot/dts/aspeed/Makefile b/arch/arm/boot/dts/aspeed/Makefile
> index fb9cc95f1b60..2b27d377aae2 100644
> --- a/arch/arm/boot/dts/aspeed/Makefile
> +++ b/arch/arm/boot/dts/aspeed/Makefile
> @@ -5,6 +5,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
> aspeed-ast2600-evb.dtb \
> aspeed-bmc-amd-daytonax.dtb \
> aspeed-bmc-amd-ethanolx.dtb \
> + aspeed-bmc-amd-onyx.dtb \
> aspeed-bmc-ampere-mtjade.dtb \
> aspeed-bmc-ampere-mtmitchell.dtb \
> aspeed-bmc-arm-stardragon4800-rep2.dtb \
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts
> new file mode 100644
> index 000000000000..a7056cd29553
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-amd-onyx.dts
> @@ -0,0 +1,98 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +// Copyright (c) 2021 - 2024 AMD Inc.
> +// Author: Supreeth Venkatesh <supreeth.venkatesh@amd.com>
> +
> +/dts-v1/;
> +
> +#include "aspeed-g6.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +
> +/ {
> + model = "AMD Onyx BMC";
> + compatible = "amd,onyx-bmc", "aspeed,ast2600";
> +
> + aliases {
> + serial0 = &uart1;
> + serial4 = &uart5;
> + };
> +
> + chosen {
> + stdout-path = &uart5;
> + bootargs = "console=ttyS4,115200 earlyprintk vmalloc=512MB";
Why `vmalloc=512MB`? Can you add a comment explaining the need for
that?
That said, setting bootargs in the devicetree is generally discouraged.
> + };
> +
> + memory@80000000 {
> + device_type = "memory";
> + reg = <0x80000000 0x80000000>;
> + };
> +
> +};
> +
> +&mdio0 {
> + status = "okay";
> +
> + ethphy0: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0>;
> + };
> +};
> +
> +&mac3 {
> + status = "okay";
> + phy-mode = "rgmii";
> + phy-handle = <ðphy0>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rgmii4_default>;
> +};
> +
> +
> +
> +&fmc {
> + status = "okay";
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + status = "okay";
> + #include "openbmc-flash-layout-128.dtsi"
> + };
> +};
> +
> +//Host Console
> +&uart1 {
> + status = "okay";
> +};
How are you managing the host console? Enabling UART1 for that on the
BMC piques my interest :)
Apologies for the delay in reviewing.
Andrew
next prev parent reply other threads:[~2024-02-26 6:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 3:35 [PATCH 1/1] ARM:dts:aspeed: Initial device tree for AMD Onyx Platform Supreeth Venkatesh
2024-02-08 14:57 ` Supreeth Venkatesh
2024-02-08 21:48 ` Andrew Jeffery
[not found] ` <dda6c22e-8f35-4c18-9fea-6a6295dee3a1@linaro.org>
2024-03-01 21:02 ` Supreeth Venkatesh
2024-02-26 6:55 ` Andrew Jeffery [this message]
2024-02-26 7:10 ` Paul Menzel
2024-03-01 20:54 ` Supreeth Venkatesh
2024-03-01 20:57 ` Supreeth Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572d53516dee6db5af7089090056185abb4e78c7.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=supreeth.venkatesh@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).