From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Kelly Hung <ppighouse@gmail.com>, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org,
linux-aspeed@lists.ozlabs.org, Rob Herring <robh@kernel.org>,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
kelly_hung@asus.com, joel@jms.id.au,
krzysztof.kozlowski+dt@linaro.org, Allenyy_Hsu@asus.com,
linux-arm-kernel@lists.infradead.org,
Zev Weiss <zweiss@equinix.com>
Subject: Re: [PATCH v6 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board
Date: Tue, 30 Apr 2024 10:58:57 +0930 [thread overview]
Message-ID: <6b69a2bbfa713374e0bbd9f306ee554ee99f70d3.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240326103549.2413515-2-Kelly_Hung@asus.com>
On Tue, 2024-03-26 at 18:35 +0800, Kelly Hung wrote:
> Document the new compatibles used on ASUS X4TF.
>
> Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>
In addition to the concerns of others, your author email is not the
same as your SoB email. checkpatch warns:
```
WARNING: From:/Signed-off-by: email address mismatch: 'From: Kelly Hung
<ppighouse@gmail.com>' != 'Signed-off-by: Kelly Hung
<Kelly_Hung@asus.com>'
total: 0 errors, 1 warnings, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-
inplace.
Commit bb035db4c70a ("dt-bindings: arm: aspeed: add ASUS X4TF board")
has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
```
Please fix this issue for both patches in the series and resend.
Thanks,
Andrew
next prev parent reply other threads:[~2024-04-30 1:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 10:35 [PATCH v6 0/2] Add Reviewed-by and Acked-by tags Kelly Hung
2024-03-26 10:35 ` [PATCH v6 1/2] dt-bindings: arm: aspeed: add ASUS X4TF board Kelly Hung
[not found] ` <32cd6f33-b4e9-4b7a-bcea-b1f2e421d67e@linaro.org>
2024-03-26 18:24 ` Conor Dooley
2024-04-30 1:28 ` Andrew Jeffery [this message]
2024-03-26 10:35 ` [PATCH v6 2/2] ARM: dts: aspeed: x4tf: Add dts for asus x4tf project Kelly Hung
2024-03-26 19:12 ` [PATCH v6 0/2] Add Reviewed-by and Acked-by tags Rob Herring
2024-03-27 1:46 ` Andrew Jeffery
2024-03-27 1:54 ` Chia Li Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b69a2bbfa713374e0bbd9f306ee554ee99f70d3.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=Allenyy_Hsu@asus.com \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=kelly_hung@asus.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=ppighouse@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=zweiss@equinix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).