From: Linus Walleij <linus.walleij@linaro.org>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: BMC-SW@aspeedtech.com, johnny_huang@aspeedtech.com,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
Ricky_CX_Wu@wiwynn.com, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, joel@jms.id.au,
Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] pinctrl: pinctrl-aspeed-g6: Fix register offset for pinconf of GPIOR-T
Date: Thu, 28 Mar 2024 10:15:05 +0100 [thread overview]
Message-ID: <CACRpkdaxekb_E4ttW5XfRUa+srkjOzUaVXRAtHMYjkVir7R7xQ@mail.gmail.com> (raw)
In-Reply-To: <20240313092809.2596644-1-billy_tsai@aspeedtech.com>
On Wed, Mar 13, 2024 at 10:28 AM Billy Tsai <billy_tsai@aspeedtech.com> wrote:
> The register offset to disable the internal pull-down of GPIOR~T is 0x630
> instead of 0x620, as specified in the Ast2600 datasheet v15
> The datasheet can download from the official Aspeed website.
>
> Fixes: 15711ba6ff19 ("pinctrl: aspeed-g6: Add AST2600 pinconf support")
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
Patch applied.
I recorded Delphine's similar patch as "reported-by".
Yours,
Linus Walleij
prev parent reply other threads:[~2024-03-28 9:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 9:28 [PATCH v2] pinctrl: pinctrl-aspeed-g6: Fix register offset for pinconf of GPIOR-T Billy Tsai
2024-03-13 11:08 ` Paul Menzel
2024-03-13 22:53 ` Andrew Jeffery
2024-03-28 9:15 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaxekb_E4ttW5XfRUa+srkjOzUaVXRAtHMYjkVir7R7xQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=BMC-SW@aspeedtech.com \
--cc=Delphine_CC_Chiu@wiwynn.com \
--cc=Ricky_CX_Wu@wiwynn.com \
--cc=billy_tsai@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=johnny_huang@aspeedtech.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).