From: Jim Liu <jim.t90615@gmail.com>
To: Andy Shevchenko <andy@kernel.org>
Cc: KWLIU@nuvoton.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, linus.walleij@linaro.org,
JJLIU0@nuvoton.com, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
brgl@bgdev.pl
Subject: Re: [PATCH v9 3/3] gpio: nuvoton: Add Nuvoton NPCM sgpio driver
Date: Fri, 22 Dec 2023 09:27:39 +0800 [thread overview]
Message-ID: <CAKUZ0+GhB9m5c-5PtZNM3YrXmXfDRPVH_ZKAPxecF5dQO7Jdcw@mail.gmail.com> (raw)
In-Reply-To: <CAKUZ0+EDdBnPdY828L3DUTHKyXX209cJEuFWBs7xff_6bbDWPg@mail.gmail.com>
Hi Andy
Thanks for your reply.
The description as below
> > > + in_port = GPIO_BANK(gpio->nin_sgpio);
> > > + if (GPIO_BIT(gpio->nin_sgpio) > 0)
> > > + in_port += 1;
> >
> > This is strange... So, you are telling that offsets start from 1 and not 0?
> >
> > > + out_port = GPIO_BANK(gpio->nout_sgpio);
> > > + if (GPIO_BIT(gpio->nout_sgpio) > 0)
> > > + out_port += 1;
> >
> > Ditto.
> >
> Yes, if the customer has defined the in/out pins the offsets start from 1.
>Why?
The NPCM_IOXCFG2_PORT default setting is to enable 0 input port and 0
output port.
The register default value is 0x0. Each port can support 8 pins.
If the register value is 0x31 means enable 3 output ports and 1 input port.
If customer has define nuvoton,input-ngpios or nuvoton,output-ngpios
dts property
For example , nuvoton,output-ngpios = <9>
> > > + out_port = GPIO_BANK(gpio->nout_sgpio);
The out_port value is 1 but one port only supports 8 pins.
> > > + if (GPIO_BIT(gpio->nout_sgpio) > 0)
> > > + out_port += 1;
This out_port value is 2, the driver will enable two port to support 9 pins.
Maybe it is my expression error , the out_port and in_port default value is 0.
> The NPCM_IOXCFG2_PORT register is the set number of in/out ports.
> NPCM_IOXCFG2_PORT register define as below:
> 0~3 bit is the number of input ports
> 4~7 bit is the number of output ports
> Each module can support 8 input ports and 8 output ports.
Best regards,
Jim
prev parent reply other threads:[~2023-12-22 1:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 6:51 [PATCH v9 0/3] Add Nuvoton NPCM SGPIO feature Jim Liu
2023-12-12 6:51 ` [PATCH v9 1/3] dt-bindings: gpio: add NPCM sgpio driver bindings Jim Liu
2023-12-12 7:00 ` Paul Menzel
2023-12-12 8:41 ` Jim Liu
2023-12-12 6:51 ` [PATCH v9 2/3] arm: dts: nuvoton: npcm: Add sgpio feature Jim Liu
2023-12-12 6:51 ` [PATCH v9 3/3] gpio: nuvoton: Add Nuvoton NPCM sgpio driver Jim Liu
2023-12-13 15:27 ` Andy Shevchenko
2023-12-21 6:27 ` Jim Liu
2023-12-21 16:28 ` Andy Shevchenko
2023-12-22 1:27 ` Jim Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKUZ0+GhB9m5c-5PtZNM3YrXmXfDRPVH_ZKAPxecF5dQO7Jdcw@mail.gmail.com \
--to=jim.t90615@gmail.com \
--cc=JJLIU0@nuvoton.com \
--cc=KWLIU@nuvoton.com \
--cc=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).