From: "Kelly Hung(洪嘉莉)" <Kelly_Hung@asus.com>
To: Tom Rini <trini@konsulko.com>, Kelly Hung <ppighouse@gmail.com>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: RE: [PATCH] dts: ast2600: add x4tf dts for asus product
Date: Thu, 1 Feb 2024 09:58:15 +0000 [thread overview]
Message-ID: <SEYPR04MB66025F0A9565C6F827C41E5E9D432@SEYPR04MB6602.apcprd04.prod.outlook.com> (raw)
In-Reply-To: <SEYPR04MB660286EF00E67DF8DDB63F599D432@SEYPR04MB6602.apcprd04.prod.outlook.com>
Hi, Tom,
Q:
> + model = "AST2600 ASUS";
> + compatible = "aspeed,ast2600-asus", "aspeed,ast2600";
A: I do a modification, replace "ast2600-evb" with "ast2600-asus".
Q: All of these are bootph* now.
And is there effort being made to upstream the dts files for these platforms to Linux?
A: Yes, I also git send-email to kernel related persons to add a asus dts in kernel device tree.
My typo, I would like to correct it.
> @@ -0,0 +1,239 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +// Copyright 2023 ASUS Corp.
Thans for review.
Best Regards
Kelly
-----Original Message-----
From: Tom Rini <trini@konsulko.com>
Sent: Tuesday, January 30, 2024 11:09 PM
To: Kelly Hung <ppighouse@gmail.com>
Cc: u-boot@lists.denx.de; openbmc@lists.ozlabs.org; Kelly Hung(洪嘉莉) <Kelly_Hung@asus.com>
Subject: Re: [PATCH] dts: ast2600: add x4tf dts for asus product
On Tue, Jan 30, 2024 at 06:40:45PM +0800, Kelly Hung wrote:
> This initial device-tree provides the necessary configuration for
> basic BMC functionality and work on ASUS X4TF production.
>
> Signed-off-by: Kelly Hung <Kelly_Hung@asus.com>
> ---
> arch/arm/dts/Makefile | 3 +-
> arch/arm/dts/ast2600-x4tf.dts | 239
> ++++++++++++++++++++++++++++++++++
[snip]
> diff --git a/arch/arm/dts/ast2600-x4tf.dts
> b/arch/arm/dts/ast2600-x4tf.dts new file mode 100644 index
> 00000000..3c478058
> --- /dev/null
> +++ b/arch/arm/dts/ast2600-x4tf.dts
> @@ -0,0 +1,239 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +// Copyright 2020 IBM Corp.
> +/dts-v1/;
> +
> +#include "ast2600-u-boot.dtsi"
> +
> +/ {
> + model = "AST2600 ASUS";
> + compatible = "aspeed,ast2600-evb", "aspeed,ast2600";
Compatible should be board unique.
> +&uart5 {
> + u-boot,dm-pre-reloc;
All of these are bootph* now.
And is there effort being made to upstream the dts files for these platforms to Linux?
--
Tom
===================================================================================================================================
This email and any attachments to it contain confidential information and are intended solely for the use of the individual to whom it is addressed. If you are not the intended recipient or receive it accidentally, please immediately notify the sender by e-mail and delete the message and any attachments from your computer system, and destroy all hard copies. Please be advised that any unauthorized disclosure, copying, distribution or any action taken or omitted in reliance on this, is illegal and prohibited. Any views or opinions expressed are solely those of the author and do not represent those of ASUSTeK.
For pricing information, ASUS is only entitled to set a recommendation resale price. All customers are free to set their own price as they wish.
===================================================================================================================================
prev parent reply other threads:[~2024-02-01 21:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 10:40 [PATCH] dts: ast2600: add x4tf dts for asus product Kelly Hung
2024-01-30 15:09 ` Tom Rini
2024-02-01 9:22 ` Kelly Hung(洪嘉莉)
2024-02-01 9:58 ` Kelly Hung(洪嘉莉) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SEYPR04MB66025F0A9565C6F827C41E5E9D432@SEYPR04MB6602.apcprd04.prod.outlook.com \
--to=kelly_hung@asus.com \
--cc=openbmc@lists.ozlabs.org \
--cc=ppighouse@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).