From: "Winiarska, Iwona" <iwona.winiarska@intel.com>
To: "ricardo@marliere.net" <ricardo@marliere.net>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] peci: constify the struct device_type usage
Date: Mon, 26 Feb 2024 13:49:22 +0000 [thread overview]
Message-ID: <ad75133abd5a56f7fd46899df38aaa086eab7edb.camel@intel.com> (raw)
In-Reply-To: <20240219-device_cleanup-peci-v1-1-0727662616f7@marliere.net>
On Mon, 2024-02-19 at 09:36 -0300, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the
> peci_controller_type and peci_device_type variables to be constant
> structures as well, placing it into read-only memory which can not be
> modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com>
Thanks
-Iwona
> ---
> drivers/peci/core.c | 2 +-
> drivers/peci/device.c | 2 +-
> drivers/peci/internal.h | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/peci/core.c b/drivers/peci/core.c
> index 0f83a9c6093b..ab22d7d1948f 100644
> --- a/drivers/peci/core.c
> +++ b/drivers/peci/core.c
> @@ -25,7 +25,7 @@ static void peci_controller_dev_release(struct device *dev)
> kfree(controller);
> }
>
> -struct device_type peci_controller_type = {
> +const struct device_type peci_controller_type = {
> .release = peci_controller_dev_release,
> };
>
> diff --git a/drivers/peci/device.c b/drivers/peci/device.c
> index e6b0bffb14f4..ee01f03c29b7 100644
> --- a/drivers/peci/device.c
> +++ b/drivers/peci/device.c
> @@ -246,7 +246,7 @@ static void peci_device_release(struct device *dev)
> kfree(device);
> }
>
> -struct device_type peci_device_type = {
> +const struct device_type peci_device_type = {
> .groups = peci_device_groups,
> .release = peci_device_release,
> };
> diff --git a/drivers/peci/internal.h b/drivers/peci/internal.h
> index 9d75ea54504c..fddae86bf13c 100644
> --- a/drivers/peci/internal.h
> +++ b/drivers/peci/internal.h
> @@ -75,7 +75,7 @@ struct peci_device_id {
> u8 model;
> };
>
> -extern struct device_type peci_device_type;
> +extern const struct device_type peci_device_type;
> extern const struct attribute_group *peci_device_groups[];
>
> int peci_device_create(struct peci_controller *controller, u8 addr);
> @@ -129,7 +129,7 @@ void peci_driver_unregister(struct peci_driver *driver);
> #define module_peci_driver(__peci_driver) \
> module_driver(__peci_driver, peci_driver_register,
> peci_driver_unregister)
>
> -extern struct device_type peci_controller_type;
> +extern const struct device_type peci_controller_type;
>
> int peci_controller_scan_devices(struct peci_controller *controller);
>
>
> ---
> base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d
> change-id: 20240219-device_cleanup-peci-a4f87c77703a
>
> Best regards,
prev parent reply other threads:[~2024-02-26 13:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 12:36 [PATCH] peci: constify the struct device_type usage Ricardo B. Marliere
2024-02-26 13:49 ` Winiarska, Iwona [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad75133abd5a56f7fd46899df38aaa086eab7edb.camel@intel.com \
--to=iwona.winiarska@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=ricardo@marliere.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).