From: "Winiarska, Iwona" <iwona.winiarska@intel.com>
To: "rdunlap@infradead.org" <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH v2] peci: linux/peci.h: fix Excess kernel-doc description warning
Date: Wed, 3 Apr 2024 23:13:27 +0000 [thread overview]
Message-ID: <c28853d7e563482c5682e6cbbe5fcf20f218e487.camel@intel.com> (raw)
In-Reply-To: <20240329182910.29495-1-rdunlap@infradead.org>
On Fri, 2024-03-29 at 11:29 -0700, Randy Dunlap wrote:
> Remove the @controller: line to prevent the kernel-doc warning:
>
> include/linux/peci.h:84: warning: Excess struct member 'controller'
> description in 'peci_device'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Iwona Winiarska <iwona.winiarska@intel.com>
> Cc: openbmc@lists.ozlabs.org
> Reviewed-by: Iwona Winiarska <iwona.winiarska@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> v2: add Rev-by, add gregkh email
>
> Would it make sense to add Greg as M: in the MAINTAINERS file?
> How does someone know to Cc: Greg on PECI patches?
Hi Randy,
Normally I was taking PECI related patches into peci-next [1] and sending a PR
to Greg. Unfortunately, I didn't manage to send it in v6.9 cycle, which is why
your patch didn't land in mainline yet. Sorry about that delay.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/iwi/linux.git/log/?h=peci-next
-Iwona
>
> include/linux/peci.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff -- a/include/linux/peci.h b/include/linux/peci.h
> --- a/include/linux/peci.h
> +++ b/include/linux/peci.h
> @@ -58,7 +58,6 @@ static inline struct peci_controller *to
> /**
> * struct peci_device - PECI device
> * @dev: device object to register PECI device to the device model
> - * @controller: manages the bus segment hosting this PECI device
> * @info: PECI device characteristics
> * @info.family: device family
> * @info.model: device model
prev parent reply other threads:[~2024-04-03 23:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 18:29 [PATCH v2] peci: linux/peci.h: fix Excess kernel-doc description warning Randy Dunlap
2024-04-03 23:13 ` Winiarska, Iwona [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c28853d7e563482c5682e6cbbe5fcf20f218e487.camel@intel.com \
--to=iwona.winiarska@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).