From: Quan Nguyen <quan@os.amperecomputing.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>,
linux-kernel@vger.kernel.org,
Phong Vo <phong@os.amperecomputing.com>,
Wolfram Sang <wsa@kernel.org>,
Brendan Higgins <brendan.higgins@linux.dev>,
Joel Stanley <joel@jms.id.au>, Cosmo Chou <chou.cosmo@gmail.com>,
Open Source Submission <patches@amperecomputing.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v3 1/2] i2c: aspeed: Handle the coalesced stop conditions with the start conditions.
Date: Mon, 11 Dec 2023 11:09:08 +0700 [thread overview]
Message-ID: <ffcacd0f-85a3-4c9f-9d0d-50425fec4775@os.amperecomputing.com> (raw)
In-Reply-To: <20231209202810.r7kkz2hlaonyibha@zenone.zhora.eu>
On 10/12/2023 03:28, Andi Shyti wrote:
> Hi Quan,
>
> On Fri, Dec 08, 2023 at 10:31:41AM +0700, Quan Nguyen wrote:
>> Some masters may drive the transfers with low enough latency between
>> the nak/stop phase of the current command and the start/address phase
>> of the following command that the interrupts are coalesced by the
>> time we process them.
>> Handle the stop conditions before processing SLAVE_MATCH to fix the
>> complaints that sometimes occur below.
>>
>> "aspeed-i2c-bus 1e78a040.i2c-bus: irq handled != irq. Expected
>> 0x00000086, but was 0x00000084"
>>
>> Fixes: f9eb91350bb2 ("i2c: aspeed: added slave support for Aspeed I2C driver")
>> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
>
> Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
>
Thanks Andi,
I'll add your Reviewed-by in v4
Thanks,
- Quan
next prev parent reply other threads:[~2023-12-11 4:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 3:31 [PATCH v3 0/2] i2c: aspeed: Late ack Tx done irqs and handle coalesced start with stop conditions Quan Nguyen
2023-12-08 3:31 ` [PATCH v3 1/2] i2c: aspeed: Handle the coalesced stop conditions with the start conditions Quan Nguyen
2023-12-08 3:56 ` Andrew Jeffery
2023-12-11 4:08 ` Quan Nguyen
2023-12-09 20:28 ` Andi Shyti
2023-12-11 4:09 ` Quan Nguyen [this message]
2023-12-08 3:31 ` [PATCH v3 2/2] i2c: aspeed: Acknowledge Tx done with and without ACK irq late Quan Nguyen
2023-12-08 4:00 ` Andrew Jeffery
2023-12-11 4:06 ` Quan Nguyen
2023-12-09 20:44 ` Andi Shyti
2023-12-11 4:06 ` Quan Nguyen
2023-12-11 4:06 ` Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffcacd0f-85a3-4c9f-9d0d-50425fec4775@os.amperecomputing.com \
--to=quan@os.amperecomputing.com \
--cc=andi.shyti@kernel.org \
--cc=brendan.higgins@linux.dev \
--cc=chou.cosmo@gmail.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=thang@os.amperecomputing.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).