From: Ola x Nilsson <ola.x.nilsson@axis.com>
To: <olani@axis.com>
Cc: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] oeqa/selftest/devtool: add test for modifying recipes using go.bbclass
Date: Fri, 17 May 2024 10:56:52 +0200 [thread overview]
Message-ID: <jwqy1887r57.fsf@axis.com> (raw)
In-Reply-To: <20240517085410.2598110-1-olani@axis.com> (olani@axis.com's message of "Fri, 17 May 2024 10:54:10 +0200")
On Fri, May 17 2024, olani@axis.com wrote:
> From: Ola x Nilsson <olani@axis.com>
>
> go.bbclass uses a special do_unpack function that causes the git root
> to be different from S. Verify that it unpacks as expected.
>
> [ YOCTO #15483 ]
>
> Signed-off-by: Ola x Nilsson <olani@axis.com>
> ---
>
> Changes since v1:
> Correct author
>
> meta/lib/oeqa/selftest/cases/devtool.py | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/meta/lib/oeqa/selftest/cases/devtool.py b/meta/lib/oeqa/selftest/cases/devtool.py
> index 882225dde3..fc08906117 100644
> --- a/meta/lib/oeqa/selftest/cases/devtool.py
> +++ b/meta/lib/oeqa/selftest/cases/devtool.py
> @@ -753,6 +753,25 @@ class DevtoolModifyTests(DevtoolBase):
> result = runCmd('devtool status')
> self.assertNotIn('mdadm', result.output)
>
> + def test_devtool_modify_go(self):
> + import oe.path
> + from tempfile import TemporaryDirectory
> + with TemporaryDirectory(prefix='devtoolqa') as tempdir:
> + self.track_for_cleanup(self.workspacedir)
> + self.add_command_to_tearDown('bitbake -c clean go-helloworld')
> + self.add_command_to_tearDown('bitbake-layers remove-layer */workspace')
> + result = runCmd('devtool modify go-helloworld -x %s' % tempdir)
> + self.assertExists(
> + oe.path.join(tempdir, 'src', 'golang.org', 'x', 'example', 'go.mod'),
> + 'Extracted source could not be found'
> + )
> + self.assertExists(
> + oe.path.join(self.workspacedir, 'conf', 'layer.conf'),
> + 'Workspace directory not created'
> + )
> + matches = glob.glob(oe.path.join(self.workspacedir, 'appends', 'go-helloworld_*.bbappend'))
> + self.assertTrue(matches, 'bbappend not created %s' % result.output)
> +
> def test_devtool_buildclean(self):
> def assertFile(path, *paths):
> f = os.path.join(path, *paths)
I realize that this test doesn't really solve the problem of "papering
over" the problem in devtool modify, but I hope it at least protects
against some breakage.
/Ola
prev parent reply other threads:[~2024-05-17 8:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 8:54 [PATCH v2] oeqa/selftest/devtool: add test for modifying recipes using go.bbclass olani
2024-05-17 8:56 ` Ola x Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwqy1887r57.fsf@axis.com \
--to=ola.x.nilsson@axis.com \
--cc=olani@axis.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).