From: Yoann Congal <yoann.congal@smile.fr>
To: openembedded-devel@lists.openembedded.org
Cc: Yoann Congal <yoann.congal@smile.fr>,
Alexandre Truong <alexandre.truong@smile.fr>
Subject: [meta-networking][PATCH] mdio-tools: fix mdio-netlink kernel module reproducibility
Date: Tue, 21 May 2024 10:08:05 +0200 [thread overview]
Message-ID: <20240521080805.1415945-1-yoann.congal@smile.fr> (raw)
mdio-netlink source make reference to ${S}/.. which breaks
-fdebug-prefix-map and results in the full TMPDIR path being present in
the -dbg package and, also, change a related CRC in the main package.
This changes ${S} to enclose the whole SRC_URI repo and adapt relative paths to
build (MODULES_MODULE_SYMVERS_LOCATION)
This make mdio-netlink reproducible and fixes this warning:
WARNING: mdio-netlink-1.3.1-r0 do_package_qa: QA Issue: File /lib/modules/6.6.29-yocto-standard/updates/.debug/mdio-netlink.ko in package mdio-netlink-dbg contains reference to TMPDIR [buildpaths]
Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
Reviewed-by: Alexandre Truong <alexandre.truong@smile.fr>
---
NB: I could only test that the module does load correctly and works for
an empty MDIO bus. But, diffoscope of before/after the patch show only
change on the debug side, so it should be safe enough.
---
meta-networking/conf/include/non-repro-meta-networking.inc | 2 --
.../recipes-support/mdio-tools/mdio-netlink_1.3.1.bb | 5 +++--
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/meta-networking/conf/include/non-repro-meta-networking.inc b/meta-networking/conf/include/non-repro-meta-networking.inc
index e0f448fe31..45eed5398e 100755
--- a/meta-networking/conf/include/non-repro-meta-networking.inc
+++ b/meta-networking/conf/include/non-repro-meta-networking.inc
@@ -15,7 +15,6 @@ KNOWN_NON_REPRO_META_NETWORKING = " \
htpdate-doc \
keepalived \
keepalived-dbg \
- kernel-module-mdio-netlink-6.6.17-yocto-standard \
libbearssl-staticdev \
libfko3 \
libfko-client \
@@ -25,7 +24,6 @@ KNOWN_NON_REPRO_META_NETWORKING = " \
libowfat-staticdev \
libruli-staticdev \
libsamba-util0 \
- mdio-netlink-dbg \
mosquitto \
mosquitto-dbg \
ncftp \
diff --git a/meta-networking/recipes-support/mdio-tools/mdio-netlink_1.3.1.bb b/meta-networking/recipes-support/mdio-tools/mdio-netlink_1.3.1.bb
index b50d33f908..3867b89052 100644
--- a/meta-networking/recipes-support/mdio-tools/mdio-netlink_1.3.1.bb
+++ b/meta-networking/recipes-support/mdio-tools/mdio-netlink_1.3.1.bb
@@ -3,11 +3,12 @@ require mdio-tools.inc
DEPENDS += "virtual/kernel libmnl"
# This module requires Linux 5.6 higher
-S = "${WORKDIR}/git/kernel"
+S = "${WORKDIR}/git"
inherit module
-EXTRA_OEMAKE = "KDIR=${STAGING_KERNEL_DIR}"
+EXTRA_OEMAKE = "-C kernel/ KDIR=${STAGING_KERNEL_DIR}"
+MODULES_MODULE_SYMVERS_LOCATION="kernel"
MODULES_INSTALL_TARGET = "install"
RPROVIDES:${PN} += "kernel-module-mdio-netlink"
--
2.39.2
reply other threads:[~2024-05-21 8:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240521080805.1415945-1-yoann.congal@smile.fr \
--to=yoann.congal@smile.fr \
--cc=alexandre.truong@smile.fr \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).