From: Andi Shyti <andi.shyti@kernel.org>
To: Calvince Otieno <calvncce@gmail.com>
Cc: outreachy@lists.linux.dev, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Luke Koch <lu.ale.koch@gmail.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Simon Horman <horms@kernel.org>,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: wlan-ng: remove helper function prism2sta_inf_handover()
Date: Fri, 13 Oct 2023 11:45:03 +0200 [thread overview]
Message-ID: <20231013094503.6xnohuoivlysmlpp@zenone.zhora.eu> (raw)
In-Reply-To: <ZSkKux4LMgYiaNMx@lab-ubuntu>
Hi Calvince,
...
> -/*
> - * prism2sta_inf_handover
> - *
> - * Handles the receipt of a Handover info frame. Should only be present
> - * in APs only.
> - *
> - * Arguments:
> - * wlandev wlan device structure
> - * inf ptr to info frame (contents in hfa384x order)
> - *
> - * Returns:
> - * nothing
> - *
> - * Side effects:
> - *
> - * Call context:
> - * interrupt
> - */
> -static void prism2sta_inf_handover(struct wlandevice *wlandev,
> - struct hfa384x_inf_frame *inf)
> -{
> - pr_debug("received infoframe:HANDOVER (unhandled)\n");
> -}
> -
> /*
> * prism2sta_inf_tallies
> *
> @@ -1724,7 +1697,7 @@ void prism2sta_ev_info(struct wlandevice *wlandev,
> /* Dispatch */
> switch (inf->infotype) {
> case HFA384x_IT_HANDOVERADDR:
> - prism2sta_inf_handover(wlandev, inf);
> + pr_debug("received infoframe:HANDOVER (unhandled)\n");
while I think the patch is correct, I believe you should take
this opportunity to use a better printing function. I am not a
network developer, but I believe network people would prefer
netdev_dbg() at this point.
The pr_*() family is one of the most generic printing method,
useful for debug and few other situations. Other printing
functions should be preferred because the provide more context.
Andi
prev parent reply other threads:[~2023-10-13 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 9:15 [PATCH] staging: wlan-ng: remove helper function prism2sta_inf_handover() Calvince Otieno
2023-10-13 9:45 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231013094503.6xnohuoivlysmlpp@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=calvncce@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lu.ale.koch@gmail.com \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).