outreachy.lists.linux.dev archive mirror
 help / color / mirror / Atom feed

From: Soumya Negi <soumya.negi97@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Martyn Welch <martyn@welchs.me.uk>,
	Manohar Vanga <manohar.vanga@gmail.com>
Cc: outreachy@lists.linux.dev
Subject: Need advice on planning patches for staging/vme_user
Date: Sun, 15 Oct 2023 18:41:09 -0700	[thread overview]
Message-ID: <20231016014109.GA6619@Negi> (raw)

Hi,

There are printk's in the staging driver vme_user(all in 1 file) which triggers
checkpatch warnings all over. To replace printk() with appropriate logging 
mechanisms(a mix of dev_err/warn & pr_err/warn), if I go by a patch for each 
function that calls printk, the patchset will be too big(~33 patches). 

Or, if I split up patches this way: printk() to pr_*() & 
printk() to dev_*(), there would be fewer patches(atleast 4) but perhaps
it will be harder to review? (There are ~78 call sites)

What would be a good way to structure the patchset?

Plus there are some other changes, like  using __func__ instead of func
name in printk error messages, that can be done. Is it okay to make this
change in the error string while replacing the printk() or does it need to be
in a separate patch( after the printk's are replaced)?

Thanks,
Soumya

                 reply	other threads:[~2023-10-16  1:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231016014109.GA6619@Negi \
    --to=soumya.negi97@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=manohar.vanga@gmail.com \
    --cc=martyn@welchs.me.uk \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).