From: Piro Yang <piroyangg@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Piro Yang <piroyangg@gmail.com>,
linux-staging@lists.linux.dev,
Linux Outreachy <outreachy@lists.linux.dev>,
linux-kernel@vger.kernel.org
Subject: [PATCH V3] staging:vme_user:Fix the issue of return the wrong error code
Date: Tue, 19 Dec 2023 23:12:02 +0800 [thread overview]
Message-ID: <20231219151202.50368-1-piroyangg@gmail.com> (raw)
Fix the issue of returning the -ENOSYS error code when an error occurs
The error code of -ENOSYS indicates Invalid system call number, but there is not system call error
Replace -ENOSYS error code by returning -EINVAL error code
Signed-off-by: Piro Yang <piroyangg@gmail.com>
---
v3: change the description and format for the patch
v2: split two different changes,
only fix the issue of wrong error code
---
drivers/staging/vme_user/vme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
index 5c416c31ec57..9bc2d35405af 100644
--- a/drivers/staging/vme_user/vme.c
+++ b/drivers/staging/vme_user/vme.c
@@ -341,7 +341,7 @@ int vme_slave_set(struct vme_resource *resource, int enabled,
if (!bridge->slave_set) {
dev_err(bridge->parent, "Function not supported\n");
- return -ENOSYS;
+ return -EINVAL;
}
if (!(((image->address_attr & aspace) == aspace) &&
--
2.25.1
next reply other threads:[~2023-12-19 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 15:12 Piro Yang [this message]
2023-12-19 15:18 ` [PATCH V3] staging:vme_user:Fix the issue of return the wrong error code Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219151202.50368-1-piroyangg@gmail.com \
--to=piroyangg@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).