From: Dorcas Litunya <anonolitunya@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: outreachy@lists.linux.dev,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] Staging: sm750fb: Rename displayControl
Date: Mon, 16 Oct 2023 23:30:50 +0300 [thread overview]
Message-ID: <ZS2deicLPyamwb5T@dorcaslitunya-virtual-machine> (raw)
In-Reply-To: <a5cbf027-7990-c54d-8bfc-dc042ac166f@inria.fr>
On Sun, Oct 15, 2023 at 10:23:54PM +0200, Julia Lawall wrote:
>
>
> On Sun, 15 Oct 2023, Dorcas AnonoLitunya wrote:
>
> > Rename variable displayControl to display_control. This follows
> > snakecase naming convention and ensures consistent naming style
> > throughout the file.Issue by checkpatch.
>
> Actually, the variable seems to be dispControl?
>
I had actually missed this. Thanks for the correction. Its now corrected
in v2.
Dorcas
> julia
>
> >
> > Mutes the following checkpatch error:
> > CHECK: Avoid CamelCase: <dispControl>
> >
> > Signed-off-by: Dorcas AnonoLitunya <anonolitunya@gmail.com>
> > ---
> > drivers/staging/sm750fb/ddk750_mode.c | 32 +++++++++++++--------------
> > 1 file changed, 16 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> > index 431b273a347a..fc3db09de9ae 100644
> > --- a/drivers/staging/sm750fb/ddk750_mode.c
> > +++ b/drivers/staging/sm750fb/ddk750_mode.c
> > @@ -15,7 +15,7 @@
> > */
> > static unsigned long
> > display_control_adjust_SM750LE(struct mode_parameter *mode_param,
> > - unsigned long dispControl)
> > + unsigned long disp_control)
> > {
> > unsigned long x, y;
> >
> > @@ -36,42 +36,42 @@ display_control_adjust_SM750LE(struct mode_parameter *mode_param,
> > ((x - 1) & CRT_AUTO_CENTERING_BR_RIGHT_MASK));
> >
> > /*
> > - * Assume common fields in dispControl have been properly set before
> > + * Assume common fields in disp_control have been properly set before
> > * calling this function.
> > - * This function only sets the extra fields in dispControl.
> > + * This function only sets the extra fields in disp_control.
> > */
> >
> > /* Clear bit 29:27 of display control register */
> > - dispControl &= ~CRT_DISPLAY_CTRL_CLK_MASK;
> > + disp_control &= ~CRT_DISPLAY_CTRL_CLK_MASK;
> >
> > /* Set bit 29:27 of display control register for the right clock */
> > /* Note that SM750LE only need to supported 7 resolutions. */
> > if (x == 800 && y == 600)
> > - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL41;
> > + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL41;
> > else if (x == 1024 && y == 768)
> > - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL65;
> > + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL65;
> > else if (x == 1152 && y == 864)
> > - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL80;
> > + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL80;
> > else if (x == 1280 && y == 768)
> > - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL80;
> > + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL80;
> > else if (x == 1280 && y == 720)
> > - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL74;
> > + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL74;
> > else if (x == 1280 && y == 960)
> > - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL108;
> > + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL108;
> > else if (x == 1280 && y == 1024)
> > - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL108;
> > + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL108;
> > else /* default to VGA clock */
> > - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL25;
> > + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL25;
> >
> > /* Set bit 25:24 of display controller */
> > - dispControl |= (CRT_DISPLAY_CTRL_CRTSELECT | CRT_DISPLAY_CTRL_RGBBIT);
> > + disp_control |= (CRT_DISPLAY_CTRL_CRTSELECT | CRT_DISPLAY_CTRL_RGBBIT);
> >
> > /* Set bit 14 of display controller */
> > - dispControl |= DISPLAY_CTRL_CLOCK_PHASE;
> > + disp_control |= DISPLAY_CTRL_CLOCK_PHASE;
> >
> > - poke32(CRT_DISPLAY_CTRL, dispControl);
> > + poke32(CRT_DISPLAY_CTRL, disp_control);
> >
> > - return dispControl;
> > + return disp_control;
> > }
> >
> > /* only timing related registers will be programed */
> > --
> > 2.42.0.345.gaab89be2eb
> >
> >
> >
next prev parent reply other threads:[~2023-10-16 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 20:12 [PATCH 0/5] staging: sm750fb: Renaming camelcase to snakecase Dorcas AnonoLitunya
2023-10-15 20:12 ` [PATCH 1/5] Staging: sm750fb: Rename displayControlAdjust_SM750E Dorcas AnonoLitunya
2023-10-15 20:22 ` Julia Lawall
2023-10-16 20:29 ` Dorcas Litunya
2023-10-15 20:12 ` [PATCH 2/5] Staging: sm750fb: Rename pModeParam Dorcas AnonoLitunya
2023-10-15 20:12 ` [PATCH 3/5] Staging: sm750fb: Rename displayControl Dorcas AnonoLitunya
2023-10-15 20:23 ` Julia Lawall
2023-10-16 20:30 ` Dorcas Litunya [this message]
2023-10-15 20:12 ` [PATCH 4/5] Staging: sm750fb: Rename programModeRegisters Dorcas AnonoLitunya
2023-10-15 20:12 ` [PATCH 5/5] Staging: sm750fb: Rename ddk750_setModeTiming Dorcas AnonoLitunya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS2deicLPyamwb5T@dorcaslitunya-virtual-machine \
--to=anonolitunya@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).