From: Julia Lawall <julia.lawall@inria.fr>
To: Calvince Otieno <calvncce@gmail.com>
Cc: gustavo@embeddedor.com, outreachy@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: vme_user: fix coding style - remove CamelCasing
Date: Wed, 18 Oct 2023 10:13:28 +0200 (CEST) [thread overview]
Message-ID: <baa4e15-6c4c-a2ae-259a-f6cae6de837f@inria.fr> (raw)
In-Reply-To: <CADFX3OQbXXaa1z+4-tOhidb2w_XH9sYB0x1_yLZ69yDy_1Nwpw@mail.gmail.com>
> As description states, checkpatch recommendation
This comment should be just under my text, that you are responding to, not
at the end of the patch.
CamelCase is not just the mixture of uppercase and lowercase letters. It
means that the things with upper and lowercase letters are real words,
LikeThis. In the case of this driver, the lowercase letter was not part
of an English word, so one can be suspicious that it has some other
meaning. Checkpatch doesn't know what are real English words, so it makes
the suggestions whenever there is a mixture of uppercase and lowercase
letters.
julia
next prev parent reply other threads:[~2023-10-18 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 7:22 [PATCH] staging: vme_user: fix coding style - remove CamelCasing Calvince Otieno
2023-10-18 7:27 ` Julia Lawall
2023-10-18 7:29 ` Calvince Otieno
2023-10-18 8:13 ` Julia Lawall [this message]
2023-10-18 7:40 ` Greg Kroah-Hartman
2023-10-18 7:47 ` Karolina Stolarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baa4e15-6c4c-a2ae-259a-f6cae6de837f@inria.fr \
--to=julia.lawall@inria.fr \
--cc=calvncce@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).