From: Ivor Wanders <ivor@iwanders.net>
To: ilpo.jarvinen@linux.intel.com
Cc: hdegoede@redhat.com, ivor@iwanders.net,
linux-kernel@vger.kernel.org, luzmaximilian@gmail.com,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 1/1] platform/surface: platform_profile: add fan profile switching
Date: Mon, 11 Mar 2024 18:32:30 -0400 [thread overview]
Message-ID: <20240311223230.4653-1-ivor@iwanders.net> (raw)
In-Reply-To: <fa16bf5a-b0da-2751-7109-fe76acbcd7d8@linux.intel.com>
> Is char correct type here or do you perhaps mean e.g., u8 that is more
approriate for 1-byte long binary data? [...] u8 ?
Thanks for the review Ilpo. Agreed, u8 would be better, I also noticed that
this variable, and the profile_le one in the function just above it can be
const, I'll change this type to u8 and make both profile variable const in v2.
~Ivor
next prev parent reply other threads:[~2024-03-11 22:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 17:01 [PATCH 0/1] platform/surface: platform_profile: add fan profile switching Ivor Wanders
2024-03-02 17:01 ` [PATCH 1/1] " Ivor Wanders
2024-03-11 11:46 ` Ilpo Järvinen
2024-03-11 22:32 ` Ivor Wanders [this message]
2024-03-09 0:58 ` [PATCH 0/1] " Maximilian Luz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311223230.4653-1-ivor@iwanders.net \
--to=ivor@iwanders.net \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).