From: "Luke Jones" <luke@ljones.dev>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org,
"Hans de Goede" <hdegoede@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] platform/x86: asus-wmi: add support for Vivobook GPU MUX
Date: Thu, 21 Mar 2024 09:07:41 +1300 [thread overview]
Message-ID: <33a380bd-e3fd-4022-a707-1d14319f202a@app.fastmail.com> (raw)
In-Reply-To: <c7e375df-e709-a348-a240-0d6d8bde1840@linux.intel.com>
On Thu, 21 Mar 2024, at 1:02 AM, Ilpo Järvinen wrote:
> On Wed, 20 Mar 2024, Luke Jones wrote:
>
> > On Wed, 20 Mar 2024, at 1:26 AM, Ilpo Järvinen wrote:
> > > On Sun, 10 Mar 2024, Luke D. Jones wrote:
> > >
> > > > Adjust existing MUX support to select whichever MUX support is available
> > > > so that ASUS Vivobook MUX can also be used if detected.
> > >
> > > This description is a bit on the short side. It wouldn't have hurt to
> > > first state that Vivobooks come with a GPU MUX WMI that has a different
> > > WMI device ID. I can infer that after reading the diff but the description
> > > should not require reading the patch.
> >
> > Would you prefer I changed the commit message?
>
> I kind of tried to give some leeway for you and not sound like I'm
> enforcing you to do it but yes,
Hey it's not a problem at all. Part of the review and all feedback is valuable :)
prev parent reply other threads:[~2024-03-20 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 5:53 [PATCH v2 0/1] asus-wmi: add support for Vivobook GPU MUX Luke D. Jones
2024-03-10 5:53 ` [PATCH v2 1/1] platform/x86: " Luke D. Jones
2024-03-19 12:26 ` Ilpo Järvinen
2024-03-20 1:04 ` Luke Jones
2024-03-20 12:02 ` Ilpo Järvinen
2024-03-20 20:07 ` Luke Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33a380bd-e3fd-4022-a707-1d14319f202a@app.fastmail.com \
--to=luke@ljones.dev \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).