From: Hans de Goede <hdegoede@redhat.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: p2sb: Make p2sb_get_devfn() return void
Date: Mon, 25 Mar 2024 15:39:18 +0100 [thread overview]
Message-ID: <42a58d00-87e2-43b7-8a9d-ec167e2a5d25@redhat.com> (raw)
In-Reply-To: <mkrcd6it2ejerpwpxevq6obxbzz374fh7lc6fltqtxizugoqq2@kwvzznyqmflh>
Hi,
On 3/6/24 2:58 AM, Shinichiro Kawasaki wrote:
> On Mar 05, 2024 / 10:45, Hans de Goede wrote:
>> p2sb_get_devfn() always succeeds, make it return void and
>> remove error checking from its callers.
>>
>> Cc: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Thanks, looks good to me.
>
> Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Thank you.
I've added this to my review-hans (soon to be for-next) branch now.
Regards,
Hans
prev parent reply other threads:[~2024-03-25 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 9:45 [PATCH] platform/x86: p2sb: Make p2sb_get_devfn() return void Hans de Goede
2024-03-06 1:58 ` Shinichiro Kawasaki
2024-03-25 14:39 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42a58d00-87e2-43b7-8a9d-ec167e2a5d25@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).