From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
To: "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>
Cc: AceLan Kao <acelan.kao@canonical.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: intel-vbtn: Log event code on unexpected button events
Date: Wed, 27 Mar 2024 16:36:26 -0700 [thread overview]
Message-ID: <5c9bcf27-0b57-4750-960f-e01a08149b93@linux.intel.com> (raw)
In-Reply-To: <20240327195712.43851-1-hdegoede@redhat.com>
On 3/27/24 12:57 PM, Hans de Goede wrote:
> When logging the warning about receiving a button event on a device
> without buttons log the event code which triggered the warning.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
Looks good to me.
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> drivers/platform/x86/intel/vbtn.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/vbtn.c b/drivers/platform/x86/intel/vbtn.c
> index 084c355c86f5..de4decbb13ba 100644
> --- a/drivers/platform/x86/intel/vbtn.c
> +++ b/drivers/platform/x86/intel/vbtn.c
> @@ -158,7 +158,8 @@ static void notify_handler(acpi_handle handle, u32 event, void *context)
>
> if ((ke = sparse_keymap_entry_from_scancode(priv->buttons_dev, event))) {
> if (!priv->has_buttons) {
> - dev_warn(&device->dev, "Warning: received a button event on a device without buttons, please report this.\n");
> + dev_warn(&device->dev, "Warning: received 0x%02x button event on a device without buttons, please report this.\n",
> + event);
> return;
> }
> input_dev = priv->buttons_dev;
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
prev parent reply other threads:[~2024-03-27 23:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 19:57 [PATCH] platform/x86: intel-vbtn: Log event code on unexpected button events Hans de Goede
2024-03-27 23:36 ` Kuppuswamy Sathyanarayanan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c9bcf27-0b57-4750-960f-e01a08149b93@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=acelan.kao@canonical.com \
--cc=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).