From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
amd-gfx@lists.freedesktop.org,
"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>,
linux-fbdev@vger.kernel.org, nouveau@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org,
intel-xe@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
"open list:ACPI" <linux-acpi@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"Melissa Wen" <mwen@igalia.com>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>
Subject: Re: [PATCH v6 3/5] drm: Add support to get EDID from ACPI
Date: Wed, 17 Apr 2024 16:18:10 +0200 [thread overview]
Message-ID: <CAMuHMdV1XYpu3JeP3W-dZpO8kmN75XckuPRnw2zLW-ZqD4634g@mail.gmail.com> (raw)
In-Reply-To: <ecbaadf9-dfa1-46af-9a7e-cfd7aa1120be@amd.com>
Hi Mario,
On Thu, Feb 15, 2024 at 8:04 PM Mario Limonciello
<mario.limonciello@amd.com> wrote:
> On 2/15/2024 12:47, Ville Syrjälä wrote:
> > On Thu, Feb 15, 2024 at 12:20:56PM -0600, Mario Limonciello wrote:
> >> On 2/14/2024 17:13, Ville Syrjälä wrote:
> >>> On Wed, Feb 14, 2024 at 03:57:54PM -0600, Mario Limonciello wrote:
> >>>> --- a/include/drm/drm_connector.h
> >>>> +++ b/include/drm/drm_connector.h
> >>>> @@ -1886,6 +1886,12 @@ struct drm_connector {
> >>>>
> >>>> /** @hdr_sink_metadata: HDR Metadata Information read from sink */
> >>>> struct hdr_sink_metadata hdr_sink_metadata;
> >>>> +
> >>>> + /**
> >>>> + * @acpi_edid_allowed: Get the EDID from the BIOS, if available.
> >>>> + * This is only applicable to eDP and LVDS displays.
> >>>> + */
> >>>> + bool acpi_edid_allowed;
> >>>
> >>> Aren't there other bools/small stuff in there for tighter packing?
> >>
> >> Does the compiler automatically do the packing if you put bools nearby
> >> in a struct? If so; TIL.
> >
> > Yes. Well, depends on the types and their alignment requirements
> > of course, and/or whether you specified __packed or not.
> >
> > You can use 'pahole' to find the holes in structures.
>
> Thanks! I don't see a __packed attribute on struct drm_connector, but
> I'll put it near by other bools in case that changes in the future.
FTR, don't add __packed unless you have a very good reason to do so.
With __packed, the compiler will emit multiple byte-accesses to
access multi-byte integrals on platforms that do not support unaligned
memory access.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2024-04-17 14:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 21:57 [PATCH v6 0/5] Add support for getting EDID over ACPI to DRM Mario Limonciello
2024-02-14 21:57 ` [PATCH v6 1/5] drm: Stop using `select ACPI_VIDEO` in all drivers Mario Limonciello
2024-02-15 20:47 ` kernel test robot
2024-02-15 20:59 ` kernel test robot
2024-02-16 0:49 ` kernel test robot
2024-02-16 0:49 ` kernel test robot
2024-02-16 5:03 ` kernel test robot
2024-02-16 9:03 ` kernel test robot
2024-02-16 9:24 ` kernel test robot
2024-02-16 13:01 ` kernel test robot
2024-02-16 17:11 ` kernel test robot
2024-02-16 21:18 ` kernel test robot
2024-02-17 1:34 ` kernel test robot
2024-02-17 5:36 ` kernel test robot
2024-02-17 9:51 ` kernel test robot
2024-02-14 21:57 ` [PATCH v6 2/5] drm: Stop using `select BACKLIGHT_CLASS_DEVICE` Mario Limonciello
2024-02-14 21:57 ` [PATCH v6 3/5] drm: Add support to get EDID from ACPI Mario Limonciello
2024-02-14 23:13 ` Ville Syrjälä
2024-02-15 14:13 ` Jani Nikula
2024-02-15 18:20 ` Mario Limonciello
2024-02-15 18:47 ` Ville Syrjälä
2024-02-15 19:03 ` Mario Limonciello
2024-04-17 14:18 ` Geert Uytterhoeven [this message]
2024-02-15 14:09 ` Jani Nikula
2024-02-14 21:57 ` [PATCH v6 4/5] drm/amd: Fetch the EDID from _DDC if available for eDP Mario Limonciello
2024-02-14 21:57 ` [PATCH v6 5/5] drm/nouveau: Use drm_edid_read_acpi() helper Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdV1XYpu3JeP3W-dZpO8kmN75XckuPRnw2zLW-ZqD4634g@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=mwen@igalia.com \
--cc=nouveau@lists.freedesktop.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).