From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Mohamed Ghanmi <mohamed.ghanmi@supcom.tn>
Cc: "Luke D. Jones" <luke@ljones.dev>,
Hans de Goede <hdegoede@redhat.com>,
corentin.chary@gmail.com, platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-wmi: add support for vivobook fan profiles
Date: Wed, 17 Apr 2024 09:28:44 +0300 (EEST) [thread overview]
Message-ID: <e61ddc4f-5e55-248c-72fa-3c15d6316961@linux.intel.com> (raw)
In-Reply-To: <Zh6oooU-DL2IXLg9@laptop>
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
On Tue, 16 Apr 2024, Mohamed Ghanmi wrote:
> On Tue, Apr 16, 2024 at 03:51:03PM +0300, Ilpo Järvinen wrote:
> > On Sun, 14 Apr 2024, Luke D. Jones wrote:
> >
> > > From: Mohamed Ghanmi <mohamed.ghanmi@supcom.tn>
> > >
> > > Add support for vivobook fan profiles wmi call on the ASUS VIVOBOOK
> > > to adjust power limits.
> > >
> > > These fan profiles have a different device id than the ROG series.
> > > and different order.
> >
> > Fix grammar.
>
> my grammar is not the greatest so i'm finding it hard to know what is
> the error you're referring to but I think that 'add'
> should become 'adds' ?
That's not what I was referring to, you've a dangling/broken "sentence"
right in front of my reply:
"and different order."
Please fix that. Perhaps you just want to remove the stop (".") from
the previous sentence to join the sentences together?
--
i.
prev parent reply other threads:[~2024-04-17 6:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-13 20:21 [PATCH] platform/x86: asus-wmi: add support for vivobook fan profiles Luke D. Jones
2024-04-16 12:51 ` Ilpo Järvinen
2024-04-16 16:34 ` Mohamed Ghanmi
2024-04-17 6:28 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e61ddc4f-5e55-248c-72fa-3c15d6316961@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=mohamed.ghanmi@supcom.tn \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).