From: "Alexandre Belloni" <alexandre.belloni@bootlin.com>
To: George Kelly <george.kelly1097@gmail.com>
Cc: poky@lists.yoctoproject.org, George Kelly <gkelly@phoenixcontact.com>
Subject: Re: [poky] [PULL] [PATCH 1/1] bitbake: fetch2: Add NODE_EXTRA_CA_CERTS to the list of exports
Date: Fri, 3 Feb 2023 22:05:28 +0100 [thread overview]
Message-ID: <Y913GNz0hk4BPi7m@mail.local> (raw)
In-Reply-To: <c486378d098e4a5cb89b712dbd6b66e9b67f7dde.1675447409.git.gkelly@phoenixcontact.com>
Hello George,
Thanks for the patch, a few things to improve:
On 03/02/2023 15:29:43-0500, George Kelly wrote:
> From: George Kelly <gkelly@phoenixcontact.com>
>
> if you are behind a corporate proxy, the npm fetcher uses the proxy IP address already passed in the list of exports. However, it will error if the proxy injects its own root CA certificate. Thus, the NODE_EXTRA_CA_CERTS environment variable must be passed so the user can include their company's root CA as a trusted CA inside node's certificate store.
This commit message should be wrapped
>
> Signed-off-by: George Kelly <george.kelly1097@gmail.com>
The Author and SoB must match.
> ---
> bitbake/lib/bb/fetch2/__init__.py | 1 +
This is a bitake patch, please base it on the bitbake git repository
(git.openembedded.org/bitbake).
Also, this should be sent to bitbake-devel@lists.openembedded.org
> 1 file changed, 1 insertion(+)
>
> diff --git a/bitbake/lib/bb/fetch2/__init__.py b/bitbake/lib/bb/fetch2/__init__.py
> index 5a7a6024d1..747356dfa1 100644
> --- a/bitbake/lib/bb/fetch2/__init__.py
> +++ b/bitbake/lib/bb/fetch2/__init__.py
> @@ -851,6 +851,7 @@ FETCH_EXPORT_VARS = ['HOME', 'PATH',
> 'DBUS_SESSION_BUS_ADDRESS',
> 'P4CONFIG',
> 'SSL_CERT_FILE',
> + 'NODE_EXTRA_CA_CERTS',
> 'AWS_PROFILE',
> 'AWS_ACCESS_KEY_ID',
> 'AWS_SECRET_ACCESS_KEY',
> --
> 2.37.2
>
>
>
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2023-02-03 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 20:29 [PULL] [PATCH 0/1] bitbake: fetch2: Add NODE_EXTRA_CA_CERTS to the list of exports George Kelly
2023-02-03 20:29 ` [PULL] [PATCH 1/1] " George Kelly
2023-02-03 21:05 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y913GNz0hk4BPi7m@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=george.kelly1097@gmail.com \
--cc=gkelly@phoenixcontact.com \
--cc=poky@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).