From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4Zob-00023U-97 for qemu-devel@nongnu.org; Thu, 03 Dec 2015 14:45:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a4ZoW-00012g-9p for qemu-devel@nongnu.org; Thu, 03 Dec 2015 14:45:17 -0500 Received: from mx2.suse.de ([195.135.220.15]:38885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a4ZoW-00012N-3A for qemu-devel@nongnu.org; Thu, 03 Dec 2015 14:45:12 -0500 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 97373ADEB for ; Thu, 3 Dec 2015 19:45:11 +0000 (UTC) From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Thu, 3 Dec 2015 20:45:06 +0100 Message-Id: <1449171909-22018-2-git-send-email-afaerber@suse.de> In-Reply-To: <1449171909-22018-1-git-send-email-afaerber@suse.de> References: <1449171909-22018-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 1/4] tests: Fix check-report-qtest-% target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Andreas=20F=C3=A4rber?= Commit e253c28 ("tests: Fix how qom-test is run") introduced $(qtest-generic-y) and used it for check-qtest-% target, but did not update check-report-qtest-%. This causes check-report-qtest-aarch64.xml target to fail with a gtester usage error for lack of test arguments. Fix this by adding $(qtest-generic-y) in check-report-qtest-%. Also add it in check-clean target, spotted by Markus. Reviewed-by: Markus Armbruster Signed-off-by: Andreas F=C3=A4rber --- tests/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index 0ef00a1..a1d03b4 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -612,7 +612,7 @@ $(patsubst %, check-%, $(check-unit-y)): check-%: % $(patsubst %, check-report-qtest-%.xml, $(QTEST_TARGETS)): check-report-= qtest-%.xml: $(check-qtest-y) $(call quiet-command,QTEST_QEMU_BINARY=3D$*-softmmu/qemu-system-$* \ QTEST_QEMU_IMG=3Dqemu-img$(EXESUF) \ - gtester -q $(GTESTER_OPTIONS) -o $@ -m=3D$(SPEED) $(check-qtest-$*-y)= ,"GTESTER $@") + gtester -q $(GTESTER_OPTIONS) -o $@ -m=3D$(SPEED) $(check-qtest-$*-y)= $(check-qtest-generic-y),"GTESTER $@") =20 check-report-unit.xml: $(check-unit-y) $(call quiet-command,gtester -q $(GTESTER_OPTIONS) -o $@ -m=3D$(SPEED) = $^, "GTESTER $@") @@ -660,7 +660,7 @@ check: check-qapi-schema check-unit check-qtest check-clean: $(MAKE) -C tests/tcg clean rm -rf $(check-unit-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y) - rm -rf $(sort $(foreach target,$(SYSEMU_TARGET_LIST), $(check-qtest-$(t= arget)-y))) + rm -rf $(sort $(foreach target,$(SYSEMU_TARGET_LIST), $(check-qtest-$(t= arget)-y)) $(check-qtest-generic-y)) =20 clean: check-clean =20 --=20 2.6.2