* [PATCH] linux-user: Remove pgb_dynamic alignment assertion
@ 2024-02-14 4:54 Richard Henderson
2024-02-15 7:03 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Richard Henderson @ 2024-02-14 4:54 UTC (permalink / raw
To: qemu-devel; +Cc: alex.bennee
The assertion was never correct, because the alignment is a composite
of the image alignment and SHMLBA. Even if the alignment didn't match
the image an assertion would not be correct -- more appropriate would
be an error message about an ill formed image. But the image cannot
be held to SHMLBA under any circumstances.
Fixes: ee94743034b ("linux-user: completely re-write init_guest_space")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2157
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/elfload.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index f3f1ab4f69..d92d66ca1e 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -3022,8 +3022,6 @@ static void pgb_dynamic(const char *image_name, uintptr_t guest_loaddr,
uintptr_t brk, ret;
PGBAddrs ga;
- assert(QEMU_IS_ALIGNED(guest_loaddr, align));
-
/* Try the identity map first. */
if (pgb_addr_set(&ga, guest_loaddr, guest_hiaddr, true)) {
brk = (uintptr_t)sbrk(0);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] linux-user: Remove pgb_dynamic alignment assertion
2024-02-14 4:54 [PATCH] linux-user: Remove pgb_dynamic alignment assertion Richard Henderson
@ 2024-02-15 7:03 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-02-15 7:03 UTC (permalink / raw
To: Richard Henderson, qemu-devel; +Cc: alex.bennee, Alexey Sheplyakov
On 14/2/24 05:54, Richard Henderson wrote:
> The assertion was never correct, because the alignment is a composite
> of the image alignment and SHMLBA. Even if the alignment didn't match
> the image an assertion would not be correct -- more appropriate would
> be an error message about an ill formed image. But the image cannot
> be held to SHMLBA under any circumstances.
Reported-by: Alexey Sheplyakov <asheplyakov@yandex.ru>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Fixes: ee94743034b ("linux-user: completely re-write init_guest_space")
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2157
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/elfload.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index f3f1ab4f69..d92d66ca1e 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -3022,8 +3022,6 @@ static void pgb_dynamic(const char *image_name, uintptr_t guest_loaddr,
> uintptr_t brk, ret;
> PGBAddrs ga;
>
> - assert(QEMU_IS_ALIGNED(guest_loaddr, align));
> -
> /* Try the identity map first. */
> if (pgb_addr_set(&ga, guest_loaddr, guest_hiaddr, true)) {
> brk = (uintptr_t)sbrk(0);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-15 7:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-14 4:54 [PATCH] linux-user: Remove pgb_dynamic alignment assertion Richard Henderson
2024-02-15 7:03 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).