From: Amjad Alsharafi <amjadsharafi10@gmail.com>
To: qemu-devel@nongnu.org
Cc: Hanna Reitz <hreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
"open list:vvfat" <qemu-block@nongnu.org>,
Amjad Alsharafi <amjadsharafi10@gmail.com>
Subject: [PATCH v2 1/5] vvfat: Fix bug in writing to middle of file
Date: Sat, 4 May 2024 16:44:19 +0800 [thread overview]
Message-ID: <2871281d8ea41fb4d7ef8f9beeaba017a1717019.1714811679.git.amjadsharafi10@gmail.com> (raw)
In-Reply-To: <cover.1714811679.git.amjadsharafi10@gmail.com>
Before this commit, the behavior when calling `commit_one_file` for
example with `offset=0x2000` (second cluster), what will happen is that
we won't fetch the next cluster from the fat, and instead use the first
cluster for the read operation.
This is due to off-by-one error here, where `i=0x2000 !< offset=0x2000`,
thus not fetching the next cluster.
Signed-off-by: Amjad Alsharafi <amjadsharafi10@gmail.com>
---
block/vvfat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 9d050ba3ae..ab342f0743 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2525,7 +2525,7 @@ commit_one_file(BDRVVVFATState* s, int dir_index, uint32_t offset)
return -1;
}
- for (i = s->cluster_size; i < offset; i += s->cluster_size)
+ for (i = s->cluster_size; i <= offset; i += s->cluster_size)
c = modified_fat_get(s, c);
fd = qemu_open_old(mapping->path, O_RDWR | O_CREAT | O_BINARY, 0666);
--
2.44.0
next prev parent reply other threads:[~2024-05-04 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 8:44 [PATCH v2 0/5] vvfat: Fix write bugs for large files and add iotests Amjad Alsharafi
2024-05-04 8:44 ` Amjad Alsharafi [this message]
2024-05-04 8:44 ` [PATCH v2 2/5] vvfat: Fix usage of `info.file.offset` Amjad Alsharafi
2024-05-04 8:44 ` [PATCH v2 3/5] vvfat: Fix reading files with non-continuous clusters Amjad Alsharafi
2024-05-04 8:44 ` [PATCH v2 4/5] iotests: Add `vvfat` tests Amjad Alsharafi
2024-05-04 8:44 ` [PATCH v2 5/5] iotests: Filter out `vvfat` fmt from failing tests Amjad Alsharafi
2024-05-04 8:51 ` [PATCH v2 0/5] vvfat: Fix write bugs for large files and add iotests Amjad Alsharafi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2871281d8ea41fb4d7ef8f9beeaba017a1717019.1714811679.git.amjadsharafi10@gmail.com \
--to=amjadsharafi10@gmail.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).