From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 4/4] configs: disable emulators that require it if libfdt is not found
Date: Tue, 7 May 2024 09:51:33 +0200 [thread overview]
Message-ID: <2db3a42b-8d90-44e9-b10a-cef05c91ceae@linaro.org> (raw)
In-Reply-To: <20240507071948.105022-5-pbonzini@redhat.com>
On 7/5/24 09:19, Paolo Bonzini wrote:
> Since boards can express their dependency on libfdt and
> system/device_tree.c, only leave TARGET_NEED_FDT if the target has a
> hard dependency.
>
> By default, unless --enable-libfdt is passed (in which case the
> dependency is mandatory, as usual for --enable-* options) or the
> target is mention in --target-list, those emulators will be skipped if
> libfdt is not present.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> configs/targets/aarch64-softmmu.mak | 1 +
> configs/targets/arm-softmmu.mak | 1 +
> configs/targets/i386-softmmu.mak | 1 -
> configs/targets/loongarch64-softmmu.mak | 1 +
> configs/targets/microblaze-softmmu.mak | 1 +
> configs/targets/microblazeel-softmmu.mak | 1 +
> configs/targets/mips64el-softmmu.mak | 1 -
> configs/targets/or1k-softmmu.mak | 1 +
> configs/targets/ppc-softmmu.mak | 1 -
> configs/targets/ppc64-softmmu.mak | 1 +
> configs/targets/riscv32-softmmu.mak | 1 +
> configs/targets/riscv64-softmmu.mak | 1 +
> configs/targets/rx-softmmu.mak | 1 +
> configs/targets/x86_64-softmmu.mak | 1 -
> meson.build | 14 ++++++++++----
> .gitlab-ci.d/buildtest.yml | 7 ++++---
> 16 files changed, 24 insertions(+), 11 deletions(-)
> - if 'TARGET_NEED_FDT' in config_target
> - fdt_required += target
> + if 'TARGET_NEED_FDT' in config_target and not fdt.found()
> + if default_targets
> + warning('Disabling ' + target + 'due to missing libfdt')
Nice.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> + else
> + fdt_required += target
> + endif
> + continue
> endif
prev parent reply other threads:[~2024-05-07 7:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 7:19 [PATCH 0/4] express dependency of individual boards on libfdt Paolo Bonzini
2024-05-07 7:19 ` [PATCH 1/4] meson: remove system/internal distinction for libfdt Paolo Bonzini
2024-05-07 7:40 ` Philippe Mathieu-Daudé
2024-05-07 7:19 ` [PATCH 2/4] kconfig: express dependency of individual boards on libfdt Paolo Bonzini
2024-05-07 7:48 ` Philippe Mathieu-Daudé
2024-05-07 10:25 ` Paolo Bonzini
2024-05-07 7:19 ` [PATCH 3/4] hw/xtensa: require libfdt Paolo Bonzini
2024-05-07 7:34 ` Philippe Mathieu-Daudé
2024-05-07 7:19 ` [PATCH 4/4] configs: disable emulators that require it if libfdt is not found Paolo Bonzini
2024-05-07 7:51 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2db3a42b-8d90-44e9-b10a-cef05c91ceae@linaro.org \
--to=philmd@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).