From: Richard Henderson <richard.henderson@linaro.org>
To: Fabiano Rosas <farosas@suse.de>, Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
"Dr . David Alan Gilbert" <dave@treblig.org>
Subject: Re: [PULL 13/13] hmp/migration: Fix documents for "migrate" command
Date: Fri, 3 May 2024 06:10:30 -0700 [thread overview]
Message-ID: <4c683c02-64fa-47b8-882c-bd19c90897de@linaro.org> (raw)
In-Reply-To: <87cyq3njnr.fsf@suse.de>
On 5/3/24 05:51, Fabiano Rosas wrote:
> Markus Armbruster <armbru@redhat.com> writes:
>
>> Fabiano Rosas <farosas@suse.de> writes:
>>
>>> From: Peter Xu <peterx@redhat.com>
>>>
>>> Peter missed the Sphinx HMP document for the "resume/-r" flag in commit
>>> 7a4da28b26 ("qmp: hmp: add migrate "resume" option"). Add it. Avoid
>>> adding a Fixes to make life easier for the stable maintainer.
>>>
>>> When at it, slightly cleanup the lines, move "detach/-d" to a separate
>>> section rather than appending it at the end of the command description.
>>>
>>> Cc: Dr. David Alan Gilbert <dave@treblig.org>
>>> Cc: Fabiano Rosas <farosas@suse.de>
>>> Cc: Markus Armbruster <armbru@redhat.com>
>>> Signed-off-by: Peter Xu <peterx@redhat.com>
>>> Reviewed-by: Fabiano Rosas <farosas@suse.de>
>>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>>> ---
>>> hmp-commands.hx | 9 +++++++--
>>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>>> index ebca2cdced..484a8a1c3a 100644
>>> --- a/hmp-commands.hx
>>> +++ b/hmp-commands.hx
>>> @@ -918,8 +918,13 @@ ERST
>>>
>>>
>>> SRST
>>> -``migrate [-d]`` *uri*
>>> - Migrate to *uri* (using -d to not wait for completion).
>>> +``migrate [-d] [-r]`` *uri*
>>> + Migrate the current VM to *uri*.
>>> +
>>> + ``-d``
>>> + Run this command asynchronously, so that the command doesn't wait for completion.
>>> + ``-r``
>>> + Resume a paused postcopy migration.
>>> ERST
>>>
>>> {
>>
>> I have questions on this one.
>
> Yep, I should have waited longer before queuing this one, my bad.
Ok, I will not process this pull request.
r~
prev parent reply other threads:[~2024-05-03 13:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 20:23 [PULL 00/13] Migration patches for 2024-05-02 Fabiano Rosas
2024-05-02 20:23 ` [PULL 01/13] migration/ram.c: API Conversion qemu_mutex_lock(), and qemu_mutex_unlock() to WITH_QEMU_LOCK_GUARD macro Fabiano Rosas
2024-05-02 20:23 ` [PULL 02/13] migration: move trace-point from migrate_fd_error to migrate_set_error Fabiano Rosas
2024-05-02 20:23 ` [PULL 03/13] migration: process_incoming_migration_co(): complete cleanup on failure Fabiano Rosas
2024-05-02 20:23 ` [PULL 04/13] migration: process_incoming_migration_co(): fix reporting s->error Fabiano Rosas
2024-05-02 20:23 ` [PULL 05/13] migration: process_incoming_migration_co(): rework error reporting Fabiano Rosas
2024-05-02 20:23 ` [PULL 06/13] qapi: introduce exit-on-error parameter for migrate-incoming Fabiano Rosas
2024-05-02 20:23 ` [PULL 07/13] migration: Remove 'skipped' field from MigrationStats Fabiano Rosas
2024-05-02 20:23 ` [PULL 08/13] migration: Remove 'inc' option from migrate command Fabiano Rosas
2024-05-02 20:23 ` [PULL 09/13] migration: Remove 'blk/-b' option from migrate commands Fabiano Rosas
2024-05-02 20:23 ` [PULL 10/13] migration: Remove block migration Fabiano Rosas
2024-05-02 20:23 ` [PULL 11/13] migration: Remove non-multifd compression Fabiano Rosas
2024-05-02 20:23 ` [PULL 12/13] migration: Deprecate fd: for file migration Fabiano Rosas
2024-05-02 20:23 ` [PULL 13/13] hmp/migration: Fix documents for "migrate" command Fabiano Rosas
2024-05-03 6:59 ` Markus Armbruster
2024-05-03 12:51 ` Fabiano Rosas
2024-05-03 13:10 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c683c02-64fa-47b8-882c-bd19c90897de@linaro.org \
--to=richard.henderson@linaro.org \
--cc=armbru@redhat.com \
--cc=dave@treblig.org \
--cc=farosas@suse.de \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).