QEMU-Devel Archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org
Subject: Re: [PATCH 0/3] testing/next: s390x gitlab updates
Date: Fri, 3 May 2024 18:17:49 -0700	[thread overview]
Message-ID: <50c27a9f-fd75-4f8e-9a2d-488d8df4f9b9@linaro.org> (raw)
In-Reply-To: <20240426153938.1707723-1-alex.bennee@linaro.org>

On 4/26/24 08:39, Alex Bennée wrote:
> I was asked to update the custom gitlab runner from the aging 20.04 to
> 22.04 which has been done. However I needed to update the provisioning
> scripts and clean-up some of the cruft. Sadly this doesn't seem to be
> passing cleanly as we have:
> 
>    - qtest-s390x/migration-test ERROR           98.94s   killed by signal 6 SIGABRT
>    - failing TCG tests (on s390x HW)
>       - float_convd fails against a generated reference
>       - clc returns 1

I've had a look at the clc failure.

It fails because of bad address space layout, where the NULL page isn't unmapped, so the 
expected SIGSEGV does *not* happen.

This is unfortunate and we could do better.

However, with the upgrade, --static --enable-pie no longer works.
 From config.log,

cc -m64 -Werror -fPIE -DPIE -o config-temp/qemu-conf.exe config-temp/qemu-conf.c -static-pie
/usr/bin/ld: cannot find rcrt1.o: No such file or directory

which suggests a missing package.

Alternately, we could drop --static, as it's not really relevant to this testing.  With 
that, we get PIE dynamically linked executables, which do not trigger the bad layout.

But at some point we should make sure that the NULL page(s) are reserved PROT_NONE for the 
guest, which ensure this stays fixed.


r~



      parent reply	other threads:[~2024-05-04  1:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-26 15:39 [PATCH 0/3] testing/next: s390x gitlab updates Alex Bennée
2024-04-26 15:39 ` [PATCH 1/3] build-environment: make some packages optional Alex Bennée
2024-04-26 15:47   ` Thomas Huth
2024-04-26 15:39 ` [PATCH 2/3] gitlab: migrate the s390x custom machine to 22.04 Alex Bennée
2024-04-26 15:47   ` Thomas Huth
2024-04-26 15:39 ` [PATCH 3/3] gitlab: remove stale s390x-all-linux-static conf hacks Alex Bennée
2024-04-26 15:49   ` Thomas Huth
2024-05-04  1:17 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50c27a9f-fd75-4f8e-9a2d-488d8df4f9b9@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).