From: Max Reitz <mreitz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Joelle van Dyne <j@getutm.app>, qemu-block@nongnu.org
Subject: Re: [PATCH v3 5/7] block: feature detection for host block support
Date: Tue, 15 Jun 2021 18:40:27 +0200 [thread overview]
Message-ID: <6a3e1f39-e14d-08e5-9c9e-85b3bab20e8d@redhat.com> (raw)
In-Reply-To: <20210603133722.218465-6-pbonzini@redhat.com>
On 03.06.21 15:37, Paolo Bonzini wrote:
> From: Joelle van Dyne <j@getutm.app>
>
> On Darwin (iOS), there are no system level APIs for directly accessing
> host block devices. We detect this at configure time.
>
> Signed-off-by: Joelle van Dyne <j@getutm.app>
> Message-Id: <20210315180341.31638-2-j@getutm.app>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/file-posix.c | 33 ++++++++++++++++++++++-----------
> meson.build | 6 +++++-
> qapi/block-core.json | 10 +++++++---
> 3 files changed, 34 insertions(+), 15 deletions(-)
[...]
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 2ea294129e..2dd41be156 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -897,7 +897,8 @@
> 'discriminator': 'driver',
> 'data': {
> 'file': 'BlockStatsSpecificFile',
> - 'host_device': 'BlockStatsSpecificFile',
> + 'host_device': { 'type': 'BlockStatsSpecificFile',
> + 'if': 'defined(HAVE_HOST_BLOCK_DEVICE)' },
> 'nvme': 'BlockStatsSpecificNvme' } }
>
> ##
> @@ -2814,7 +2815,9 @@
> { 'enum': 'BlockdevDriver',
> 'data': [ 'blkdebug', 'blklogwrites', 'blkreplay', 'blkverify', 'bochs',
> 'cloop', 'compress', 'copy-on-read', 'dmg', 'file', 'ftp', 'ftps',
> - 'gluster', 'host_cdrom', 'host_device', 'http', 'https', 'iscsi',
> + 'gluster', 'host_cdrom',
> + {'name': 'host_device', 'if': 'defined(HAVE_HOST_BLOCK_DEVICE)' },
Shouldn’t this be done for host_cdrom, too? (and below)
Apart from that, looks good to me.
> + 'http', 'https', 'iscsi',
> 'luks', 'nbd', 'nfs', 'null-aio', 'null-co', 'nvme', 'parallels',
> 'preallocate', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'rbd',
> { 'name': 'replication', 'if': 'defined(CONFIG_REPLICATION)' },
> @@ -3996,7 +3999,8 @@
> 'ftps': 'BlockdevOptionsCurlFtps',
> 'gluster': 'BlockdevOptionsGluster',
> 'host_cdrom': 'BlockdevOptionsFile',
> - 'host_device':'BlockdevOptionsFile',
> + 'host_device': { 'type': 'BlockdevOptionsFile',
> + 'if': 'defined(HAVE_HOST_BLOCK_DEVICE)' },
> 'http': 'BlockdevOptionsCurlHttp',
> 'https': 'BlockdevOptionsCurlHttps',
> 'iscsi': 'BlockdevOptionsIscsi',
next prev parent reply other threads:[~2021-06-15 16:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 13:37 [PATCH v3 0/7] block: file-posix queue Paolo Bonzini
2021-06-03 13:37 ` [PATCH v3 1/7] file-posix: fix max_iov for /dev/sg devices Paolo Bonzini
2021-06-07 5:39 ` Vladimir Sementsov-Ogievskiy
2021-06-07 6:16 ` Vladimir Sementsov-Ogievskiy
2021-06-07 7:23 ` Vladimir Sementsov-Ogievskiy
2021-06-15 15:58 ` Max Reitz
2021-06-03 13:37 ` [PATCH v3 2/7] scsi-generic: pass max_segments via max_iov field in BlockLimits Paolo Bonzini
2021-06-15 16:06 ` Max Reitz
2021-06-15 16:20 ` Max Reitz
2021-06-15 17:41 ` Paolo Bonzini
2021-06-03 13:37 ` [PATCH v3 3/7] block: add max_hw_transfer to BlockLimits Paolo Bonzini
2021-06-03 17:33 ` Eric Blake
2021-06-04 7:21 ` Paolo Bonzini
2021-06-15 16:18 ` Max Reitz
2021-06-16 13:18 ` Paolo Bonzini
2021-06-16 13:46 ` Max Reitz
2021-06-17 9:59 ` Paolo Bonzini
2021-06-03 13:37 ` [PATCH v3 4/7] file-posix: try BLKSECTGET on block devices too, do not round to power of 2 Paolo Bonzini
2021-06-15 16:32 ` Max Reitz
2021-06-03 13:37 ` [PATCH v3 5/7] block: feature detection for host block support Paolo Bonzini
2021-06-15 16:40 ` Max Reitz [this message]
2021-06-03 13:37 ` [PATCH v3 6/7] block: check for sys/disk.h Paolo Bonzini
2021-06-15 16:42 ` Max Reitz
2021-06-03 13:37 ` [PATCH v3 7/7] block: detect DKIOCGETBLOCKCOUNT/SIZE before use Paolo Bonzini
2021-06-15 16:50 ` Max Reitz
2021-06-15 16:57 ` Daniel P. Berrangé
2021-06-07 13:52 ` [PATCH v3 0/7] block: file-posix queue Maxim Levitsky
2021-06-10 13:40 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a3e1f39-e14d-08e5-9c9e-85b3bab20e8d@redhat.com \
--to=mreitz@redhat.com \
--cc=j@getutm.app \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).