From: Thomas Huth <thuth@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P. Berrange" <berrange@redhat.com>,
"Andrea Bolognani" <abologna@redhat.com>,
"Erik Skultety" <eskultet@redhat.com>,
"Michal Privoznik" <mprivozn@redhat.com>
Subject: Re: [PATCH] Re-enable riscv64-debian-cross-container (debian riscv64 is finally usable again!)
Date: Fri, 3 May 2024 07:06:03 +0200 [thread overview]
Message-ID: <7047048b-7ab2-4283-a1d1-f8e033d6f7d9@redhat.com> (raw)
In-Reply-To: <9969663a-0f00-435b-b507-fb6a429cb4db@tls.msk.ru>
On 02/05/2024 22.08, Michael Tokarev wrote:
> 02.05.2024 23:05, Richard Henderson wrote:
>> On 5/2/24 12:40, Michael Tokarev wrote:
>>> Revert "gitlab-ci: Disable the riscv64-debian-cross-container by default"
>>> This reverts commit f51f90c65ed7706c3c4f7a889ce3d6b7ab75ef6a.
>>>
>>> Hopefully it wont be very unstable.
>>>
>>> Since riscv64 is now a release architecture in debian, we can try switching
>>> to debian testing instead of debian sid. Also, debian-ports part of the
>>> archive isn't needed anymore.
>>
>> So... please update debian-riscv64-cross.docker.
>
> debian-riscv64-cross.docker is generated by lcitool.
> It looks like lcitool has to be updated for this.
Updating lcitool isn't too hard. Simply type "make lcitool-refresh" in your
build directory - this should initialize the tests/lcitool/libvirt-ci
submodule and regenerate the dockerfiles. Then you can do your change in
tests/lcitool/libvirt-ci and run the refresh command again to update the
dockerfiles. Once you're happy with the results, fork
https://gitlab.com/libvirt/libvirt-ci on gitlab, push your changes into your
fork and then open a merge request against the upstream libvirt-ci repository.
>>> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>>> ---
>>> .gitlab-ci.d/container-cross.yml | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/.gitlab-ci.d/container-cross.yml
>>> b/.gitlab-ci.d/container-cross.yml
>>> index e3103940a0..dbffed3f21 100644
>>> --- a/.gitlab-ci.d/container-cross.yml
>>> +++ b/.gitlab-ci.d/container-cross.yml
>>> @@ -77,7 +77,6 @@ riscv64-debian-cross-container:
>>> allow_failure: true
>>> variables:
>>> NAME: debian-riscv64-cross
>>> - QEMU_JOB_OPTIONAL: 1
>>
>> But you can't do this until the above is done.
>
> I don't see a reason why not. Adding debian-ports archive does nothing
> and doesn't hurt either.
>
> Switching to testing is a different matter.
>
> This thing works now with sid/unstable, this is what this patch is about.
But this doesn't match the patch description - there you talk about
switching to testing and that the ports are not needed anymore, so this is
confusing. I'd suggest to update at least the patch description if we
continue with sid.
Thomas
prev parent reply other threads:[~2024-05-03 5:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 19:40 [PATCH] Re-enable riscv64-debian-cross-container (debian riscv64 is finally usable again!) Michael Tokarev
2024-05-02 19:59 ` Michael Tokarev
2024-05-02 20:05 ` Richard Henderson
2024-05-02 20:08 ` Michael Tokarev
2024-05-02 20:41 ` Richard Henderson
2024-05-02 20:54 ` Michael Tokarev
2024-05-03 8:05 ` Daniel P. Berrangé
2024-05-03 5:06 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7047048b-7ab2-4283-a1d1-f8e033d6f7d9@redhat.com \
--to=thuth@redhat.com \
--cc=abologna@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=eskultet@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mprivozn@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).