From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 350D3C47094 for ; Thu, 10 Jun 2021 12:38:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D37B1613DF for ; Thu, 10 Jun 2021 12:38:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D37B1613DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36292 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrJwg-0003O6-R4 for qemu-devel@archiver.kernel.org; Thu, 10 Jun 2021 08:38:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrJvv-0002RR-KP for qemu-devel@nongnu.org; Thu, 10 Jun 2021 08:37:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52323) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrJvp-0008SW-FK for qemu-devel@nongnu.org; Thu, 10 Jun 2021 08:37:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623328627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l1n8gccanYkigZVxxbpKS0Add2fM0op1eMforM4vPcc=; b=DdF65eSQHlgA61jXyNR04s3lSvJRybLEUAZtiI70PXeES1IwuFFJJ/HzJ6RDk5RMYC8EgI yQx18mxrY/e9m6B5fhssrZrOD+14UMlHhJCufJ0LvNtJsg0Jkn8cc0cd8HfNJA7Qq+jI0j 2soMUiS9rCqNbTcTqUIlVYidI85mplE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-583-478ush58NDWxIZzCZAot_g-1; Thu, 10 Jun 2021 08:37:05 -0400 X-MC-Unique: 478ush58NDWxIZzCZAot_g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5E92A100C610; Thu, 10 Jun 2021 12:37:04 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-222.ams2.redhat.com [10.36.112.222]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A29B10016F8; Thu, 10 Jun 2021 12:37:04 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id BAC76113865F; Thu, 10 Jun 2021 14:37:02 +0200 (CEST) From: Markus Armbruster To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 02/11] qapi/misc-target: Group SEV QAPI definitions References: <20210610064556.1421620-1-philmd@redhat.com> <20210610064556.1421620-3-philmd@redhat.com> <875yymdpo7.fsf@dusky.pond.sub.org> <043f0098-d043-b649-9b2d-1ebee6f5f92c@redhat.com> Date: Thu, 10 Jun 2021 14:37:02 +0200 In-Reply-To: <043f0098-d043-b649-9b2d-1ebee6f5f92c@redhat.com> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Thu, 10 Jun 2021 12:15:39 +0200") Message-ID: <87o8cd6glt.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Connor Kuehl , Brijesh Singh , Eric Blake , qemu-devel@nongnu.org, "Dr . David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 writes: > On 6/10/21 11:39 AM, Markus Armbruster wrote: >> Just code motion, so >>=20 >> Acked-by: Markus Armbruster >>=20 >> Opportunity to wrap the long doc comment lines. Should be kept under 70 >> or so. > > Hmm is that a QAPI specific requirement? It is not enforced by > checkpatch, and still in the 80-90 grey area: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg763806.html Consider why we limit line length at all: it's for *legibility*. Humans tend to have trouble following long lines with our eyes (I sure do). Typographic manuals suggest to limit columns to roughly 60 characters for exactly that reason[1]. Four levels of indentation plus 60 characters of actual text yields 76. We add a grey area to provide for the occasional case where deeper indentation pushes code of reasonable width beyond the "white" area, and breaking these lines would be less legible than making use of the grey area. The lines I referred to are long for no good reason. Wrapping them will improve legibility. > (I can do if respin required, but I'd rather have this catch earlier, > not at code movement). Before, during, after, or even not at all *clank*[2], your choice. > Thanks for the A-b! [1] https://en.wikipedia.org/wiki/Column_(typography)#Typographic_style [2] Sad sound of a can being kicked down the road