From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [PATCH] configure: quote -D options that are passed to meson
Date: Tue, 7 May 2024 14:03:53 +0200 [thread overview]
Message-ID: <CABgObfaAFm1V8Vp7kYEua9a=5KTOsKzyZu9HgBssS5NNykqtpw@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA9uBWCNGDVX8C9nNV2xEHuZZPkMjHUWvvc8OM5h_ttv0Q@mail.gmail.com>
On Tue, May 7, 2024 at 1:58 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Tue, 7 May 2024 at 11:50, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > Ensure that they go through unmodified, instead of removing one layer
> > of quoting.
>
> Do you have an example of what goes wrong that we could
> mention in the commit message ?
I only found it by inspection. The only case I can think of is
"-Dpkg_config_path=/home/pbonzini/a path with spaces/".
I can add the following text:
---
-D is a pretty specialized option and most options that can have spaces
do not need it (for example, c_args is covered by --extra-cflags).
Therefore it's unlikely that this causes actual trouble. However,
a somewhat realistic failure case would be with -Dpkg_config_path
and a pkg-config directory that contains spaces.
---
Paolo
prev parent reply other threads:[~2024-05-07 12:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 10:49 [PATCH] configure: quote -D options that are passed to meson Paolo Bonzini
2024-05-07 11:23 ` Thomas Huth
2024-05-07 11:57 ` Peter Maydell
2024-05-07 12:03 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABgObfaAFm1V8Vp7kYEua9a=5KTOsKzyZu9HgBssS5NNykqtpw@mail.gmail.com' \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).