From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E121C49361 for ; Fri, 18 Jun 2021 10:10:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B862360C41 for ; Fri, 18 Jun 2021 10:10:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B862360C41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luBSj-0006oZ-MH for qemu-devel@archiver.kernel.org; Fri, 18 Jun 2021 06:10:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luBRX-0005fE-Fz for qemu-devel@nongnu.org; Fri, 18 Jun 2021 06:09:43 -0400 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]:35618) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luBRU-0004Ph-8t for qemu-devel@nongnu.org; Fri, 18 Jun 2021 06:09:43 -0400 Received: by mail-ed1-x52c.google.com with SMTP id df12so5400462edb.2 for ; Fri, 18 Jun 2021 03:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QemU3WuO9xHB+LNy4EwIuYVFgPa+wpVEi3B2glLpiRY=; b=YVj3q2hzTT79p1wlY+jTipnLmsghk+2RflVWZWGuvylfFl8bXbbdAX2vxxpcV+QalN yZB1rk4ByJIQt0yIV6c5KwcX0flVDXnxwkaf8V6+yaXC8opq9iUfOEjrX9QXM/mYPPZt vPe/eDIw9WzP+/co4YwEt8ZZv+JOuk3qSNKhdEMPhKR6NT8BalLwasas/aHQSEgILGJ+ /o5TFfjVhnCIHfOJmzlNb9+4h5bTbPIYRRZ2SXckIw8RDSShsxNLySQbXPIpUOnXJvnX 5hevp/8Hltkz41ISHSI5V5ZVTOJmwX03DhwYB1rSXl2miO8WbTN1sS1X26k4lVQVTbqs z/ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QemU3WuO9xHB+LNy4EwIuYVFgPa+wpVEi3B2glLpiRY=; b=o/8PlBTSlvgefSHADdIwlZwXduMaGWkZgAgyTNyjF5sqLStxM4J13XTGQk0JtL9AkE auUsyxPpqFUIU1p5nnEciChSoQ1XCkYXZw9AwJLfDZYFi2qnse7t8wFZX5rwZKmKKMUB KaVQ1uvsyS6ykqG7TfWshwdh4ZCRvmomfUV+ptJSJbqzKX6+efffCg0ICzmYU1/iC18n QBldrvoReGhjfrhAHaaHusM2+kRsvD+fq1pIElDtRRtVJX+Q/3UZONX5FzLCfLrgsQPZ 0k9BiWnJLrGidbHF1mYu+685kcy/Dy2PYpg16r++9id9jdgOaVP38tw+JOKIe62+36jP Yutw== X-Gm-Message-State: AOAM532LgqRz3sh715SaqCJ74Lp7OFOI9KNKRtlWmEOyxNjX7jC+P29T CVTG+98VTUs96zsipOUtegkLq928kZfc6cd2WWvYZA== X-Google-Smtp-Source: ABdhPJy0sA1EpilmXmfpc5FCTuBl8B2/TuRG9u8nme2sPMGX53frfFlJBM3GC1aSBdkl42YM4cEL/9/f5/BVw4SWTAQ= X-Received: by 2002:aa7:c857:: with SMTP id g23mr3856445edt.100.1624010978226; Fri, 18 Jun 2021 03:09:38 -0700 (PDT) MIME-Version: 1.0 References: <20210615165800.23265-1-alex.bennee@linaro.org> <20210615165800.23265-2-alex.bennee@linaro.org> In-Reply-To: From: Peter Maydell Date: Fri, 18 Jun 2021 11:09:03 +0100 Message-ID: Subject: Re: [PATCH v3 1/2] semihosting/arm-compat: replace heuristic for softmmu SYS_HEAPINFO To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Strauss , QEMU Developers , qemu-arm Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 17 Jun 2021 at 20:22, Peter Maydell wrote: > This will pick the first MR it finds that happens to be RAM (which > could be some tiny thing). You don't want that, you want specifically > whatever the board decided was the system RAM, which is the MemoryRegion > MachineState::ram. As a concrete example, on the mps3-an547 machine this code finds the 512KB ITCM at 0x0 rather than the much more useful 2GB DRAM at 0x6000_0000... -- PMM