From: Mattias Nissler <mnissler@rivosinc.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Peter Xu <peterx@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Jagannathan Raman <jag.raman@oracle.com>,
QEMU Developers <qemu-devel@nongnu.org>,
john.levon@nutanix.com, David Hildenbrand <david@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Elena Ufimtseva <elena.ufimtseva@oracle.com>
Subject: Re: [PATCH v8 0/5] Support message-based DMA in vfio-user server
Date: Tue, 7 May 2024 14:59:40 +0200 [thread overview]
Message-ID: <CAGNS4TbQP7+vMpaBBgGx+SbC1-vaz53UoP7sNPq8K6Bc5Ynarw@mail.gmail.com> (raw)
In-Reply-To: <cf640e4c-610e-4357-a9bb-57d2d4ab1254@linaro.org>
On Tue, May 7, 2024 at 2:52 PM Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> On 7/5/24 11:43, Mattias Nissler wrote:
> >
> >
> > On Mon, May 6, 2024 at 11:07 PM Mattias Nissler <mnissler@rivosinc.com
> > <mailto:mnissler@rivosinc.com>> wrote:
> >
> >
> >
> > On Mon, May 6, 2024 at 4:44 PM Peter Xu <peterx@redhat.com
> > <mailto:peterx@redhat.com>> wrote:
> >
> > On Thu, Mar 28, 2024 at 08:53:36AM +0100, Mattias Nissler wrote:
> > > Stefan, to the best of my knowledge this is fully reviewed
> > and ready
> > > to go in - can you kindly pick it up or advise in case there's
> > > something I missed? Thanks!
> >
> > Fails cross-compile on mipsel:
> >
> > https://gitlab.com/peterx/qemu/-/jobs/6787790601
> > <https://gitlab.com/peterx/qemu/-/jobs/6787790601>
> >
> >
> > Ah, bummer, thanks for reporting. 4GB of bounce buffer should be
> > plenty, so switching to 32 bit atomics seems a good idea at first
> > glance. I'll take a closer look tomorrow and send a respin with a fix.
> >
> >
> > To close the loop on this: I have posted v9 with patch #2 adjusted to
> > use uint32_t for size accounting to fix this.
>
> "size accounting" calls for portable size_t type. But if uint32_t
> satisfies our needs, OK.
To clarify, I'm referring to "bounce buffer size accounting", i.e.
keeping track of how much memory we've allocated for bounce buffers. I
don't think that there are practical use cases where anyone would want
to spend more than 4GB on bounce buffers, hence uint32_t seemed fine.
If you prefer size_t (at the expense of using different widths, which
will ultimately be visible in the command line parameter), I'm happy
to switch to that though.
next prev parent reply other threads:[~2024-05-07 13:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 10:05 [PATCH v8 0/5] Support message-based DMA in vfio-user server Mattias Nissler
2024-03-04 10:05 ` [PATCH v8 1/5] softmmu: Per-AddressSpace bounce buffering Mattias Nissler
2024-03-04 10:05 ` [PATCH v8 2/5] softmmu: Support concurrent bounce buffers Mattias Nissler
2024-03-04 10:05 ` [PATCH v8 3/5] Update subprojects/libvfio-user Mattias Nissler
2024-03-04 10:05 ` [PATCH v8 4/5] vfio-user: Message-based DMA support Mattias Nissler
2024-03-04 10:05 ` [PATCH v8 5/5] vfio-user: Fix config space access byte order Mattias Nissler
2024-03-04 10:25 ` [PATCH v8 0/5] Support message-based DMA in vfio-user server Peter Xu
2024-03-28 7:53 ` Mattias Nissler
2024-05-06 14:44 ` Peter Xu
2024-05-06 21:07 ` Mattias Nissler
2024-05-07 9:43 ` Mattias Nissler
2024-05-07 12:52 ` Philippe Mathieu-Daudé
2024-05-07 12:59 ` Mattias Nissler [this message]
2024-05-06 15:01 ` Stefan Hajnoczi
2024-05-06 21:05 ` Mattias Nissler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGNS4TbQP7+vMpaBBgGx+SbC1-vaz53UoP7sNPq8K6Bc5Ynarw@mail.gmail.com \
--to=mnissler@rivosinc.com \
--cc=david@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=jag.raman@oracle.com \
--cc=john.levon@nutanix.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).