From: Nir Soffer <nsoffer@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"open list:Block layer core" <qemu-block@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>, Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments
Date: Tue, 29 Jun 2021 18:53:12 +0300 [thread overview]
Message-ID: <CAMRbyytfdEePZ2OW6kRVHs7Ha3zJAYvRch1tt+XT_gJ64+=XPw@mail.gmail.com> (raw)
In-Reply-To: <YNsw3wRF2Zo+w9k1@redhat.com>
On Tue, Jun 29, 2021 at 5:40 PM Kevin Wolf <kwolf@redhat.com> wrote:
>
> Am 29.06.2021 um 09:23 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > 28.06.2021 20:42, Eric Blake wrote:
> > > On Wed, Jun 23, 2021 at 06:04:19PM +0200, Kevin Wolf wrote:
> > > > > This is fine, but it means that this flag will present in all ranges,
> > > > > instead of only in unallocated ranges (what this patch is doing).
> > > >
> > > > An argument for always having the flag would be that it's probably
> > > > useful for a tool to know whether a given block is actually absent or
> > > > whether it's just running an old qemu-img.
> > > >
> > > > If we didn't care about this, I would still define the actual value, but
> > > > also document a default.
> > >
> > > So to summarize, it looks like my v3 will have the best chance of
> > > approval if I go with always outputting the new field (instead of only
> > > on one of its two boolean values), and put it at the end of the JSON
> > > output.
Since the "present" key is always present, it does not need to be at the end.
> > > It also looks like we have consensus on spelling the new
> > > field "present":true for data found in the backing chain, and
> > > "present":false for places where we would defer to another file if a
> > > backing file is later added.
> > >
> >
> > I didn't follow the discussion carefully, but that sounds good to me.
>
> To me, too.
>
> > What's the decision about patch 1?
>
> I think we won't need patch 1 (and the potential backwards compatibility
> problems it would introduce) when we have this one.
Yes, looks good and patch 1 is not needed.
Nir
next prev parent reply other threads:[~2021-06-29 15:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 14:01 [PATCH v2] qemu-img: Make unallocated part of backing chain obvious in map Eric Blake
2021-06-11 14:35 ` Vladimir Sementsov-Ogievskiy
2021-06-11 14:59 ` Eric Blake
2021-06-11 18:13 ` Nir Soffer
2021-06-11 19:03 ` [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments Eric Blake
2021-06-15 8:54 ` Vladimir Sementsov-Ogievskiy
2021-06-15 13:09 ` Nir Soffer
2021-06-22 15:38 ` Kevin Wolf
2021-06-22 16:56 ` Nir Soffer
2021-06-23 8:57 ` Kevin Wolf
2021-06-23 13:58 ` Nir Soffer
2021-06-23 16:04 ` Kevin Wolf
2021-06-23 16:35 ` Nir Soffer
2021-06-28 17:42 ` Eric Blake
2021-06-29 7:23 ` Vladimir Sementsov-Ogievskiy
2021-06-29 14:40 ` Kevin Wolf
2021-06-29 15:53 ` Nir Soffer [this message]
2021-06-22 17:51 ` Vladimir Sementsov-Ogievskiy
2021-06-22 17:04 ` Nir Soffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRbyytfdEePZ2OW6kRVHs7Ha3zJAYvRch1tt+XT_gJ64+=XPw@mail.gmail.com' \
--to=nsoffer@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).