From: Roman Kiryanov <rkir@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Daniel Berrange <berrange@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
JP Cottin <jpcottin@google.com>,
Erwin Jansen <jansene@google.com>
Subject: Re: QEMU headers in C++
Date: Thu, 2 May 2024 09:04:34 -0700 [thread overview]
Message-ID: <CAOGAQeq5Mj5rpOeA5P+FiyPRN0LPE5EaU1u08s6=NjMWB-=0NQ@mail.gmail.com> (raw)
In-Reply-To: <4ead608e-7ab6-44b6-8712-fcf2e7ce6f51@redhat.com>
Hi Paolo, thank you for looking.
On Thu, May 2, 2024 at 8:19 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Anyway, just out of curiosity I tried to see what it would take to
> compile edu.c as C++ code, which I think lets us give a more informed
> answer.
>
> There were a bunch of conflicts with C++ keyword, especially "new",
> ...
>
> would not be a huge deal.
Yes, this is what I am talking about.
> So my answer is that we can't guarantee that QEMU is compilable as C++,
> but some of the changes are an improvement in general and some are a
> wash. I think accepting the latter is a small price for Google working
> on upstreaming the changes and contributing the former.
Sure, we will send the patches.
Regards,
Roman.
next prev parent reply other threads:[~2024-05-02 16:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <a href="raw">
[not found] ` </a>
2024-05-02 15:19 ` QEMU headers in C++ Paolo Bonzini
2024-05-02 16:04 ` Roman Kiryanov [this message]
2024-05-02 4:40 Roman Kiryanov
2024-05-02 6:19 ` Thomas Huth
2024-05-02 14:47 ` Warner Losh
2024-05-02 8:02 ` Daniel P. Berrangé
2024-05-02 15:17 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOGAQeq5Mj5rpOeA5P+FiyPRN0LPE5EaU1u08s6=NjMWB-=0NQ@mail.gmail.com' \
--to=rkir@google.com \
--cc=berrange@redhat.com \
--cc=jansene@google.com \
--cc=jpcottin@google.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).