From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15CAFC4743C for ; Wed, 23 Jun 2021 16:05:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A67BC60233 for ; Wed, 23 Jun 2021 16:05:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A67BC60233 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lw5Nz-00084m-RS for qemu-devel@archiver.kernel.org; Wed, 23 Jun 2021 12:05:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lw5Mf-0006L1-5v for qemu-devel@nongnu.org; Wed, 23 Jun 2021 12:04:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48895) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lw5Mc-00028L-Ip for qemu-devel@nongnu.org; Wed, 23 Jun 2021 12:04:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624464269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EpSxC+CndInHDBAYPqZP2Yhz+WwImHtCn1fIgoZQIyI=; b=U9xwHnVM6Mpb+AnwwnecHWk/KwDpVo1OmuO+In2LErBmNH2An3b1xie9CzeqwxG0ABaXvP pbdLL7ohFwx4/7X2mahfwOAt3VjyLlvKnc7Ia7Sk1xWReOLGv6w39A9m6LWz7cYHtbWpKf QLPfc0rolvEAi/dprtkyBMpQNNmprx4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-292-68sKdNrNNKKMBPdHHOaohw-1; Wed, 23 Jun 2021 12:04:26 -0400 X-MC-Unique: 68sKdNrNNKKMBPdHHOaohw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3787CC73A2; Wed, 23 Jun 2021 16:04:25 +0000 (UTC) Received: from redhat.com (ovpn-114-45.ams2.redhat.com [10.36.114.45]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6CFF910372C0; Wed, 23 Jun 2021 16:04:21 +0000 (UTC) Date: Wed, 23 Jun 2021 18:04:19 +0200 From: Kevin Wolf To: Nir Soffer Subject: Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments Message-ID: References: <20210611140157.1366738-1-eblake@redhat.com> <20210611190316.1424729-1-eblake@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.373, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sementsov-Ogievskiy , "open list:Block layer core" , Markus Armbruster , QEMU Developers , Max Reitz , Eric Blake Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 23.06.2021 um 15:58 hat Nir Soffer geschrieben: > On Wed, Jun 23, 2021 at 11:58 AM Kevin Wolf wrote: > > > > Am 22.06.2021 um 18:56 hat Nir Soffer geschrieben: > > > On Tue, Jun 22, 2021 at 6:38 PM Kevin Wolf wrote: > > > > > > > > Am 11.06.2021 um 21:03 hat Eric Blake geschrieben: > > > > > To save the user from having to check 'qemu-img info --backing-chain' > > > > > or other followup command to determine which "depth":n goes beyond the > > > > > chain, add a boolean field "backing" that is set only for unallocated > > > > > portions of the disk. > > > > > > > > > > Signed-off-by: Eric Blake > > > > > --- > > > > > > > > > > Touches the same iotest output as 1/1. If we decide that switching to > > > > > "depth":n+1 is too risky, and that the mere addition of "backing":true > > > > > while keeping "depth":n is good enough, then we'd have just one patch, > > > > > instead of this double churn. Preferences? > > > > > > > > I think the additional flag is better because it's guaranteed to be > > > > backwards compatible, and because you don't need to know the number of > > > > layers to infer whether a cluster was allocated in the whole backing > > > > chain. And by exposing ALLOCATED we definitely give access to the whole > > > > information that exists in QEMU. > > > > > > > > However, to continue with the bike shedding: I won't insist on > > > > "allocated" even if that is what the flag is called internally and > > > > consistency is usually helpful, but "backing" is misleading, too, > > > > because intuitively it doesn't cover the top layer or standalone images > > > > without a backing file. How about something like "present"? > > > > > > Looks hard to document: > > > > > > # @present: if present and false, the range is not allocated within the > > > # backing chain (since 6.1) > > > > I'm not sure why you would document it with a double negative. > > > > > And is not consistent with "offset". It would work better as: > > > > > > # @present: if present, the range is allocated within the backing > > > # chain (since 6.1) > > > > Completely ignoring the value? I would have documented it like this, but > > with "if true..." instead of "if present...". > > This is fine, but it means that this flag will present in all ranges, > instead of only in unallocated ranges (what this patch is doing). An argument for always having the flag would be that it's probably useful for a tool to know whether a given block is actually absent or whether it's just running an old qemu-img. If we didn't care about this, I would still define the actual value, but also document a default. Kevin