From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: qemu-devel@nongnu.org
Cc: anthony@xenproject.org
Subject: Re: [PATCH v3 0/3] Fix MSI-X handling for Xen HVM
Date: Mon, 6 May 2024 02:43:44 +0200 [thread overview]
Message-ID: <ZjgnwLZ__HbNauHW@mail-itl> (raw)
In-Reply-To: <cover.f5d45e3c2fb87552abfaf80982b0b724fca2134c.1714955598.git-series.marmarek@invisiblethingslab.com>
[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]
On Mon, May 06, 2024 at 02:33:19AM +0200, Marek Marczykowski-Górecki wrote:
> This series fixes handling MSI-X when device model is running in a stubdomain.
> The main part is to avoid accessing /dev/mem, which also fixes running dom0
> with lockdown enabled.
>
> It depends on a behavior change of Xen that was just comitted, and signaled
> with a feature flag. If Xen is too old (and XENFEAT_dm_msix_all_writes flag is
> not set), fallback to the old behavior.
>
> The other part is a fix to enforce read-only registers in the config space.
> This fixes MSI-X setup for iwlwifi Linux driver, as it happen to write to MSI-X
> capability id reg (as a workaround for some older device which has another
> register there). It should be no-op, but due to a bug in xen_pt code,
> it broke MSI-X detection.
>
> All those patches have been shipped in Qubes OS 4.2 already, and prove to fix
> the issue.
>
> See individual commit messages for details.
Initially I sent the series with the old Anthony's address, but just in
case I forwarded it to his new address too.
> Marek Marczykowski-Górecki (3):
> hw/xen/xen_pt: Save back data only for declared registers
> Update Xen's features.h header
> Do not access /dev/mem in MSI-X PCI passthrough on Xen
>
> hw/xen/xen_pt.c | 7 +-
> hw/xen/xen_pt_msi.c | 94 ++++++++++++++++++------------
> include/hw/xen/interface/features.h | 17 +++++-
> 3 files changed, 82 insertions(+), 36 deletions(-)
>
> base-commit: 2358f1b60f73287fe606c7ff48043b4f9e1c2d0f
> --
> git-series 0.9.1
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-05-06 0:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 0:33 [PATCH v3 0/3] Fix MSI-X handling for Xen HVM Marek Marczykowski-Górecki
2024-05-06 0:33 ` [PATCH v3 1/3] hw/xen/xen_pt: Save back data only for declared registers Marek Marczykowski-Górecki
2024-05-06 0:33 ` [PATCH v3 2/3] Update Xen's features.h header Marek Marczykowski-Górecki
2024-05-06 0:33 ` [PATCH v3 3/3] Do not access /dev/mem in MSI-X PCI passthrough on Xen Marek Marczykowski-Górecki
2024-05-06 0:43 ` Marek Marczykowski-Górecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjgnwLZ__HbNauHW@mail-itl \
--to=marmarek@invisiblethingslab.com \
--cc=anthony@xenproject.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).