From: Thomas Huth <thuth@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, ehabkost@redhat.com
Subject: Re: [PATCH v2 2/8] softfloat: Use _Generic instead of QEMU_GENERIC
Date: Tue, 15 Jun 2021 09:48:46 +0200 [thread overview]
Message-ID: <b5abcdde-b5a6-e33d-3450-386999cb43de@redhat.com> (raw)
In-Reply-To: <20210614233143.1221879-3-richard.henderson@linaro.org>
On 15/06/2021 01.31, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> fpu/softfloat.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 4d0160fe9c..6e769f990c 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -686,11 +686,13 @@ static float128 float128_pack_raw(const FloatParts128 *p)
> #include "softfloat-specialize.c.inc"
>
> #define PARTS_GENERIC_64_128(NAME, P) \
> - QEMU_GENERIC(P, (FloatParts128 *, parts128_##NAME), parts64_##NAME)
> + _Generic((P), FloatParts64 *: parts64_##NAME, \
> + FloatParts128 *: parts128_##NAME)
>
> #define PARTS_GENERIC_64_128_256(NAME, P) \
> - QEMU_GENERIC(P, (FloatParts256 *, parts256_##NAME), \
> - (FloatParts128 *, parts128_##NAME), parts64_##NAME)
> + _Generic((P), FloatParts64 *: parts64_##NAME, \
> + FloatParts128 *: parts128_##NAME, \
> + FloatParts256 *: parts256_##NAME)
>
> #define parts_default_nan(P, S) PARTS_GENERIC_64_128(default_nan, P)(P, S)
> #define parts_silence_nan(P, S) PARTS_GENERIC_64_128(silence_nan, P)(P, S)
> @@ -892,11 +894,13 @@ static void parts128_log2(FloatParts128 *a, float_status *s, const FloatFmt *f);
> */
>
> #define FRAC_GENERIC_64_128(NAME, P) \
> - QEMU_GENERIC(P, (FloatParts128 *, frac128_##NAME), frac64_##NAME)
> + _Generic((P), FloatParts64 *: frac64_##NAME, \
> + FloatParts128 *: frac128_##NAME)
>
> #define FRAC_GENERIC_64_128_256(NAME, P) \
> - QEMU_GENERIC(P, (FloatParts256 *, frac256_##NAME), \
> - (FloatParts128 *, frac128_##NAME), frac64_##NAME)
> + _Generic((P), FloatParts64 *: frac64_##NAME, \
> + FloatParts128 *: frac128_##NAME, \
> + FloatParts256 *: frac256_##NAME)
>
> static bool frac64_add(FloatParts64 *r, FloatParts64 *a, FloatParts64 *b)
> {
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2021-06-15 7:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 23:31 [PATCH v2 0/8] configure: Change to -std=gnu11 Richard Henderson
2021-06-14 23:31 ` [PATCH v2 1/8] configure: Use -std=gnu11 Richard Henderson
2021-06-15 7:43 ` Thomas Huth
2021-06-15 10:10 ` Alex Bennée
2021-06-15 13:49 ` Philippe Mathieu-Daudé
2021-06-14 23:31 ` [PATCH v2 2/8] softfloat: Use _Generic instead of QEMU_GENERIC Richard Henderson
2021-06-15 7:48 ` Thomas Huth [this message]
2021-06-15 10:18 ` Alex Bennée
2021-06-14 23:31 ` [PATCH v2 3/8] util: Use real functions for thread-posix QemuRecMutex Richard Henderson
2021-06-15 7:50 ` Thomas Huth
2021-06-15 10:54 ` Alex Bennée
2021-06-14 23:31 ` [PATCH v2 4/8] util: Pass file+line to qemu_rec_mutex_unlock_impl Richard Henderson
2021-06-15 10:56 ` Alex Bennée
2021-06-15 13:51 ` Philippe Mathieu-Daudé
2021-06-14 23:31 ` [PATCH v2 5/8] util: Use unique type for QemuRecMutex in thread-posix.h Richard Henderson
2021-06-15 7:56 ` Thomas Huth
2021-06-15 10:57 ` Alex Bennée
2021-06-14 23:31 ` [PATCH v2 6/8] include/qemu/lockable: Use _Generic instead of QEMU_GENERIC Richard Henderson
2021-06-15 11:25 ` Alex Bennée
2021-06-14 23:31 ` [PATCH v2 7/8] qemu/compiler: Remove QEMU_GENERIC Richard Henderson
2021-06-15 11:26 ` Alex Bennée
2021-06-14 23:31 ` [PATCH v2 8/8] configure: Remove probe for _Static_assert Richard Henderson
2021-06-15 7:58 ` Thomas Huth
2021-06-15 10:29 ` Alex Bennée
2021-06-14 23:42 ` [PATCH v2 0/8] configure: Change to -std=gnu11 no-reply
2021-06-16 13:04 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5abcdde-b5a6-e33d-3450-386999cb43de@redhat.com \
--to=thuth@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).